Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP "Solid colors" choice isn't respected — background is always black #35596

Closed
Brave-Matt opened this issue Jan 26, 2024 · 6 comments · Fixed by brave/brave-core#21784
Closed

Comments

@Brave-Matt
Copy link

Description

After the update to v1.62.153, the "solid colors" choice for the NTP backgrounds no longer functions properly. Regardless of what color you choose, the background is always black. This issue is present in release, Beta and Nightly builds of the browser.

Issue is present on both macOS and Windows systems.

Screen.Recording.2024-01-25.at.3.59.06.PM.mov

Miscellaneous Information:

User report:
https://community.brave.com/t/brave-color-customization-bug/528173

@rebron
Copy link
Collaborator

rebron commented Jan 26, 2024

cc: @sangwoo108 @fallaciousreasoning @kjozwiak
I think this will correct itself when we enable brave://flags/#brave-news-feed-update

@rebron rebron added the feature/brave-news formerly brave-today label Jan 26, 2024
@sangwoo108 sangwoo108 self-assigned this Jan 28, 2024
@sangwoo108
Copy link

Looks like it happens even when the flag is on. I'm on it.

@fallaciousreasoning
Copy link

Thanks @sangwoo108!

@sangwoo108
Copy link

Created uplifting reqeusts!

@kjozwiak
Copy link
Member

The above requires 1.62.155 or higher for 1.62.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 30, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 30, 2024

Verification PASSED using

Brave | 1.62.155 Chromium: 121.0.6167.85 (Official Build) (64-bit)
-- | --
Revision | 91c989228daf153ef41bd965f268fabc7b9dbbf0
OS | Windows 11 Version 23H2 (Build 22631.3085)

Reproduced the issue in 1.62.153 using STR from the description
image

Upgrade:

  1. Installed 1.62.153
  2. launched Brave
  3. clicked Customize
  4. clicked Solid colors tile and selected a color
  5. closed Brave
  6. upgraded to 1.62.155
  7. confirmed selected color choice is shown on NTP
  8. opened Dashboard again and selected different color
  9. confirmed selected color choice is shown on NTP
step 4 step 7 step 8 step 9
image image image image

Clean Install:

  1. Installed 1.62.155
  2. launched Brave
  3. clicked Customize
  4. clicked Solid colors and selected a color
  5. confirmed selected Solid colors choice is respected
step 4 step 5
image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment