Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tor daemon controller logic from browser-laptop to brave-core #359

Closed
riastradh-brave opened this issue Jun 15, 2018 · 2 comments · Fixed by brave/brave-core#4802
Closed

Comments

@riastradh-brave
Copy link
Contributor

riastradh-brave commented Jun 15, 2018

https://github.com/brave/browser-laptop/blob/8468fbb9fa0b7b3d7de8a4a377d4797c16c63758/app/tor.js (or on master)

Should be mostly a straightforward translation from nodejs state machines to C++ Chromium state machines.

@riastradh-brave riastradh-brave self-assigned this Jun 15, 2018
@bbondy bbondy added this to the Releasable builds milestone Jun 27, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Sep 30, 2018
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@darkdh darkdh self-assigned this Aug 18, 2020
@btlechowski
Copy link

btlechowski commented Oct 5, 2020

Verification passed on

Brave 1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4802

Verified OS-chosen port for tor
Opened Tor Window the first time
image

Opened Tor Window the second time
image

Verified Tor initialization progress indicator
Waiting for Tor component initialization.
image
Page is opened after Tor component initialization
image

Verified Tor process crash handling
Killed Tor process
image
Verified Tor process was relaunched after 1s
Verified client is connected to Tor network
image

Verified Tor launcher crash handling
Killed Tor launcher
image
Was not able to open the page after killing Tor Launcher
Verified Tor launcher was relaunched after closing and reopening Private Window with Tor.
Verified PID of Tor launcher changed
image
Verified client was connected to the Tor network


Verification passed with

Brave	1.16.55 Chromium: 86.0.4240.72 (Official Build) dev (x86_64)
Revision	581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#4802

OS-chosen port for tor

Initial Tor window open:

Tor window open 1

Confirmed one of the ports listed matches ~/Library/Application Support/BraveSoftware/Brave-Browser-Dev/tor/controlport

Second Tor window open:

Tor window open 2

Confirmed ports listed second time are different than the first.

Tor initialization progress indicator

Confirmed Tor tab shows initialization progress and status:

Tor initialization status 0 Screen Shot 2020-10-07 at 1 57 41 PM Screen Shot 2020-10-07 at 1 58 09 PM Screen Shot 2020-10-07 at 1 58 27 PM Tor initialization status connected

Confirmed if I try to visit a website (check.torproject.org) while Tor is initializing, the tab shows spinning indicator and progress can be seen on the tab:

spinning tab during initialization

Confirmed tab loads once Tor is initialized:

site loads when initialized
Tor process crash handling

Killed Tor process from Activity Monitor:

quit tor process

Confirmed another Tor process launched 1s later.

Confirmed able to go back to the open Tor window, visit check.torproject.org and connect to Tor network.

Tor launcher crash handling

Killed Tor Launcher from Brave's Task Manager:

step 3

Went back to the open Tor tab and confirmed I was still connected to Tor network (did a hard refresh and confirmed I got a new IP address.

Closed Tor window and opened a new one. Confirmed new Process ID and able to navigate to check.torproject.org successfully:

step 7

Verification passed on

Brave | 1.16.55 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
-- | --
Revision | 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

OS-chosen port for tor

Initial Tor window open:

image

Confirmed one of the ports listed matches .....\AppData\Local\BraveSoftware\Brave-Browser-Dev\User Data\tor\watch\controlport

image

Second Tor window open:
image

Confirmed ports listed second time are different than the first.

Tor initialization progress indicator

Confirmed Tor tab shows initialization progress and status:
image
image

Confirmed if I try to visit a website (check.torproject.org) while Tor is initializing, the tab shows spinning indicator and progress can be seen on the tab:
image

Confirmed tab loads once Tor is initialized:
image

Tor process crash handling

Killed Tor process from Activity Monitor:

image

Confirmed another Tor process launched 1s later.
Confirmed able to go back to the open Tor window, visit check.torproject.org and connect to Tor network.
image

Tor launcher crash handling

Killed Tor Launcher from Brave's Task Manager:
image

Went back to the open Tor tab and confirmed I was still connected to Tor network (did a hard refresh and confirmed I got a new IP address.

Closed Tor window and opened a new one. Confirmed new Process ID and able to navigate to check.torproject.org successfully:
image

@LaurenWags
Copy link
Member

Per discussion with @darkdh removing release-notes/include and adding release-notes/exclude. Related issue #649 will be included in the release notes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants