-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt tor daemon controller logic from browser-laptop to brave-core #359
Comments
Verification passed on
Verified test plan from brave/brave-core#4802 Verified Opened Tor Window the second time Verified Verified Verified Verification passed with
Verified test plan from brave/brave-core#4802 OS-chosen port for torInitial Tor window open: Confirmed one of the ports listed matches Second Tor window open: Confirmed ports listed second time are different than the first. Tor initialization progress indicatorConfirmed Tor tab shows initialization progress and status: Confirmed if I try to visit a website (check.torproject.org) while Tor is initializing, the tab shows spinning indicator and progress can be seen on the tab: Confirmed tab loads once Tor is initialized: Tor process crash handlingKilled Tor process from Activity Monitor: Confirmed another Tor process launched 1s later. Confirmed able to go back to the open Tor window, visit check.torproject.org and connect to Tor network. Tor launcher crash handlingKilled Tor Launcher from Brave's Task Manager: Went back to the open Tor tab and confirmed I was still connected to Tor network (did a hard refresh and confirmed I got a new IP address. Closed Tor window and opened a new one. Confirmed new Process ID and able to navigate to check.torproject.org successfully: Verification passed on
OS-chosen port for torInitial Tor window open: Confirmed one of the ports listed matches Confirmed ports listed second time are different than the first. Tor initialization progress indicatorConfirmed Tor tab shows initialization progress and status: Confirmed if I try to visit a website (check.torproject.org) while Tor is initializing, the tab shows spinning indicator and progress can be seen on the tab: Tor process crash handlingKilled Tor process from Activity Monitor: Confirmed another Tor process launched 1s later. Tor launcher crash handlingKilled Tor Launcher from Brave's Task Manager: Went back to the open Tor tab and confirmed I was still connected to Tor network (did a hard refresh and confirmed I got a new IP address. Closed Tor window and opened a new one. Confirmed new Process ID and able to navigate to check.torproject.org successfully: |
https://github.com/brave/browser-laptop/blob/8468fbb9fa0b7b3d7de8a4a377d4797c16c63758/app/tor.js (or on master)
Should be mostly a straightforward translation from nodejs state machines to C++ Chromium state machines.
The text was updated successfully, but these errors were encountered: