-
Notifications
You must be signed in to change notification settings - Fork 2.3k
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 122.0.6261.43 to Chromium 122.0.6261.57 #36242
Comments
Quick overview of the work remaining re: affected areas due to Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #35200 (comment):
Platforms that still need to check/verify the affected areas due to
|
Verification
Verify that permission request bubble works as expected - PASSEDGenerally:
1. Location - PASSED
2. Notifications - PASSED
Verify that omnibox works as expected - PASSED
Verify that syncing works as expected - PASSED
Verify that content settings work as expected - PASSEDAutoplay
Block script
Verify cookie settings/behavior - PASSEDUpdate the cookies setting
Case 1:
Case 2:
Case 3:
|
Verification
|
example | example | example | example | example | example |
---|---|---|---|---|---|
Verify PDF content extraction (AI feature) works as expected - PASSED
Verify PDF compatible with Free modal - PASSED
- installed
1.63.159
- launched Brave
- clicked on
Leo
in the sidebar - loaded and opened
https://arxiv.org/pdf/2401.01353.pdf
- clicked
Summarize this page
- confirmed that page PDF content is summarized correctly
- clicked on
Suggest questions
- confirmed that suggested questions are also relevant to PDF content
Example | Example | Example | Example | Example |
---|---|---|---|---|
Verify PDF compatible with Premium modal - PASSED
- installed
1.63.159
- launched Brave using
----env-leo=staging --env-ai-chat.bsg.dev --env-ai-chat-premium.bsg=dev --enable-logging=stderr --v=2
- clicked on
Leo
in the sidebar - logged into my
Premium
account usingaccount.bravesoftware.com
- clicked
Refresh Leo
- confirmed I had
Premium
-badging/credentials - loaded and opened
https://arxiv.org/pdf/2401.01353.pdf
- clicked
Summarize this page
- confirmed page PDF content is summarized correctly
- clicked on
Suggest questions
- confirmed suggested questions are relevant to PDF content
Example | Example | Example | Example | Example |
---|---|---|---|---|
Settings comparison - PASSED
- A new settings
Manage V8 security
is added under brave://settings/security page as part of CR122. As per the slack conversion https://bravesoftware.slack.com/archives/C7VLGSR55/p1707784332486479?thread_ts=1707520964.163159&cid=C7VLGSR55, we are going to retain this settings in Brave. - Click on the setting
Manage V8 security
redirects to V8 optimizer page
Example | Example |
---|---|
Quick commands
settings is added as part of Brave underhamburger menu>More tools>Quick commands
, confirmed that all the commands are working as expected
example | example | example | example |
---|---|---|---|
- A new content setting
Automatic picture-in-picture
is added as part of CR122
example | example |
---|---|
- A new
Saved tab groups
sync data added as part of CR122 (not sure whether we want to retain this or not, slack discussion https://bravesoftware.slack.com/archives/C7VLGSR55/p1707919993569269?thread_ts=1707520964.163159&cid=C7VLGSR55
Brave startup calls - PASSED
- Confirmed that only Brave domains are listed in Charles Proxy, Fiddler Everywhere, etc., when the build is launched with a clean profile
- Confirmed no calls to google, gstatic, etc domains when the build is launched with a clean profile
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/122.0.6261.43..122.0.6261.57?pretty=fuller&n=10000
QA tests:
Additional checks:
The text was updated successfully, but these errors were encountered: