Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 122.0.6261.43 to Chromium 122.0.6261.57 #36242

Closed
emerick opened this issue Feb 21, 2024 · 7 comments · Fixed by brave/brave-core#22194
Closed

Upgrade from Chromium 122.0.6261.43 to Chromium 122.0.6261.57 #36242

emerick opened this issue Feb 21, 2024 · 7 comments · Fixed by brave/brave-core#22194
Assignees
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@emerick
Copy link
Contributor

emerick commented Feb 21, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/122.0.6261.43..122.0.6261.57?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C122 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #35200 (comment):

Platforms that still need to check/verify the affected areas due to C122 changes as per #35200 (comment):

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit)
-- | --
Revision | 118f746822a0acc7abc8c48993a704fcd0e29122
OS | Windows 10 Version 22H2 (Build 19045.4046)

image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 21, 2024
@LaurenWags
Copy link
Member

Verified with

Brave | 1.63.159 Chromium: 122.0.6261.57 (Official Build) (x86_64)
-- | --
Revision | 118f746822a0acc7abc8c48993a704fcd0e29122
OS | macOS Version 13.6.4 (Build 22G513)
Screenshot 2024-02-21 at 8 51 16 AM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 21, 2024
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 21, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 21, 2024

Verification PASSED using

Brave	1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit) 
Revision	118f746822a0acc7abc8c48993a704fcd0e29122
OS	Linux

Verify that permission request bubble works as expected - PASSED

Generally:

  • spot checked a couple permission types
  • spot checked allow/block
  • spot checked several permission lifetime values
  • spot checked permission being correctly reflected on tune icon and under the appropriate section of brave://settings/content
  • used site where permission is requested on site open and a site where permission is requested upon user action take on site
1. Location - PASSED
  • Visited browserleaks.com/geo
  • Confirmed location permission prompt displayed as expected
  • Kept default selection of "Until I close this site" and selected "Block"
  • Confirmed permission shows as denied via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/location
Example Example Example Example
image image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/location
  • Confirmed site was no longer listed
  • Reopened site
  • Confirmed re-prompted for permission
Example Example
image image
  • Changed permission lifetime value to "1 week" and selected "Allow"
  • Confirmed permission shows as allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/location
Example Example Example Example
image image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/location
  • Confirmed site was still listed as "allowed"
  • Reopened site
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock a few days (~3)
  • Reopened browser
  • Confirmed site was still listed as "allowed" on brave://settings/content/location
  • Visited site and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example Example
image image image image
  • Advanced computer clock (~8 days from the day the permission was set)
  • Reopened browser
  • Visited brave://settings/content/location
  • Confirmed site was no longer listed on this page
  • Visited site and confirmed prompted for permission
Example Example
image image
2. Notifications - PASSED
  • Visited permission.site, selected "Notifications" button
  • Confirmed notification permission prompt displayed as expected
  • Kept default selection of "Until I close this site" and selected "Allow"
  • Confirmed permission shows as allowed via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example Example
image image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was no longer listed
  • Reopened site, selected "Notifications" button
  • Confirmed re-prompted for permission
Example Example
image image
  • Changed permission lifetime value to "24 hours" and selected "Block"
  • Confirmed permission shows as denied via tune icon in URL bar
  • Confirmed expected behavior on brave://settings/content/notifications
Example Example Example Example
image image image image
  • Closed the site
  • Waited at least 30s and looked at brave://settings/content/notifications
  • Confirmed site was still listed as "not allowed"
  • Reopened site, clicked on "Notifications" button
  • Confirmed not prompted for permission
  • Closed site, closed browser
  • Advanced computer clock 23 hrs
  • Reopened browser
  • Confirmed site was still listed as "denied" on brave://settings/content/notifications
  • Visited site, clicked "Notifications" button and confirmed not prompted for permission
  • Closed site, closed browser
Example Example Example Example Example
image image image image image
  • Advanced computer clock (25 hours from the time when the permission was set)
  • Reopened browser
  • Visited brave://settings/content/notifications
  • Confirmed site was no longer listed on this page
  • Visited site, clicked "Notifications" button and confirmed prompted for permission
Example Example
image image
Verify that omnibox works as expected - PASSED
  • Confirmed that info bar color looks as expected in light theme
  • Confirmed that info bar color looks as expected in Dark theme
  • Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
  • Confirmed that the icons in the URL bar works as expected
Light theme Dark theme Suggestions
image image image
Verify that syncing works as expected - PASSED
  • Verified the sync functionality in general it works fine without any issues
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • Confirmed the bookmarks synced across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain
  • When 2 devices are in a sync chain, remove a device resets the sync chain
  • Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain
  • Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Verify that content settings work as expected - PASSED

Autoplay

  • Confirmed that the content settings are working as expected
  • Open a Youtube.com and click on the lock icon and navigate to Site settings, look for the Autoplay settings, by default it's set to "Allow (Default)", open any video in youtube.com and ensured that the video is autoplayed.
  • Set Autoplay settings to "Block" for youtube.com and reload the youtube.com and open any video and ensured that the video is NOT autoplayed.
  • Confirmed that Autoplay was blocked on this page icon is displayed in the URL bar
Example Example Example Example
image image image image

Block script

  • Confirmed that Block scripts content settings works as expected
  • Open Twitter.com and click on the lock icon and navigate to Site settings and confirm that the Java scripts content settings is set to default "Allow(default)"
  • Set the Java scripts content settings to "Block" for Twitter and reload the twitter.com and ensured that the java scripts are blocked on this page and page doesn't load
  • Open the shields settings and ensured that the Scripts (JavaScript) is blocked via Shields
Example Example Example Example Example Example Example
image image image image image image image
Verify cookie settings/behavior - PASSED

Update the cookies setting

  1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
  2. Go to brave://settings/cookies and select Allow 3rd party cookies
  3. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is some value
  4. Go to global shield settings and ensure that the cookies setting is set to Disabled due to step 2

Case 1:

  1. Clean profile 1.64.x - CR 122
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block cross site cookies to Block all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are reatined
example example example
image image image

Case 2:

  1. Continuation of case 1
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are reatined
example example example
image image image

Case 3:

  1. Continuation of case 2
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Allow all cookies to Block cross site cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are reatined
example example example
image image image

@stephendonner
Copy link

stephendonner commented Feb 21, 2024

Verification PASSED using

Brave	1.63.159 Chromium: 122.0.6261.57 (Official Build) (64-bit) 
Revision	118f746822a0acc7abc8c48993a704fcd0e29122
OS	Linux
Verify Speedreader works as expected - PASSED
  1. installed 1.63.159
  2. launched Brave
  3. loaded https://www.vox.com/2024/2/21/24078362/inflation-car-insurance-distracted-driving-costs
  4. clicked on the Turn on Speedreader icon in the URL bar
  5. confirmed the article rendered in Speedreader mode
  6. confirmed ability to customize font, background colors, etc.
  7. confirmed ability to toggle Leo sidebar panel via Speedreader Leo button

(NOTE: cut out text-to-speech section here since it's not-yet supported on linux.I enabled it via a feature flag on startup, but it lacked any voices.)

example example example example example example
Screen Shot 2024-02-21 at 1 01 04 PM Screen Shot 2024-02-21 at 1 01 07 PM Screen Shot 2024-02-21 at 1 07 09 PM Screen Shot 2024-02-21 at 1 07 11 PM Screen Shot 2024-02-21 at 1 07 19 PM Screen Shot 2024-02-21 at 1 07 22 PM
Verify PDF content extraction (AI feature) works as expected - PASSED

Verify PDF compatible with Free modal - PASSED

  1. installed 1.63.159
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. loaded and opened https://arxiv.org/pdf/2401.01353.pdf
  5. clicked Summarize this page
  6. confirmed that page PDF content is summarized correctly
  7. clicked on Suggest questions
  8. confirmed that suggested questions are also relevant to PDF content
Example Example Example Example Example
Screen Shot 2024-02-21 at 1 37 07 PM Screen Shot 2024-02-21 at 1 37 26 PM Screen Shot 2024-02-21 at 1 38 01 PM Screen Shot 2024-02-21 at 1 38 12 PM Screen Shot 2024-02-21 at 1 38 31 PM

Verify PDF compatible with Premium modal - PASSED

  1. installed 1.63.159
  2. launched Brave using ----env-leo=staging --env-ai-chat.bsg.dev --env-ai-chat-premium.bsg=dev --enable-logging=stderr --v=2
  3. clicked on Leo in the sidebar
  4. logged into my Premium account using account.bravesoftware.com
  5. clicked Refresh Leo
  6. confirmed I had Premium-badging/credentials
  7. loaded and opened https://arxiv.org/pdf/2401.01353.pdf
  8. clicked Summarize this page
  9. confirmed page PDF content is summarized correctly
  10. clicked on Suggest questions
  11. confirmed suggested questions are relevant to PDF content
Example Example Example Example Example
Screen Shot 2024-02-21 at 1 21 24 PM Screen Shot 2024-02-21 at 1 21 38 PM Screen Shot 2024-02-21 at 1 21 55 PM Screen Shot 2024-02-21 at 1 22 09 PM Screen Shot 2024-02-21 at 1 22 31 PM

Settings comparison - PASSED

Example Example
Screen Shot 2024-02-21 at 1 42 34 PM Screen Shot 2024-02-21 at 1 42 51 PM
  • Quick commands settings is added as part of Brave under hamburger menu>More tools>Quick commands, confirmed that all the commands are working as expected
example example example example
Screen Shot 2024-02-21 at 1 49 08 PM Screen Shot 2024-02-21 at 1 49 22 PM Screen Shot 2024-02-21 at 1 49 42 PM Screen Shot 2024-02-21 at 1 49 44 PM
  • A new content setting Automatic picture-in-picture is added as part of CR122
example example
Screen Shot 2024-02-21 at 1 53 15 PM Screen Shot 2024-02-21 at 1 53 20 PM
Screen Shot 2024-02-21 at 1 55 29 PM

Brave startup calls - PASSED

  • Confirmed that only Brave domains are listed in Charles Proxy, Fiddler Everywhere, etc., when the build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the build is launched with a clean profile

@hffvld
Copy link
Contributor

hffvld commented Feb 21, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.159
Chromium: 122.0.6261.57 (Official Build) (64-bit) 

1 2
1 2

@hffvld
Copy link
Contributor

hffvld commented Feb 21, 2024

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.63.159
Chromium: 122.0.6261.57 (Official Build) (64-bit) 

1 2
1 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants