Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network selector needs alignment #36253

Closed
srirambv opened this issue Feb 21, 2024 · 1 comment · Fixed by brave/brave-core#23600
Closed

Network selector needs alignment #36253

srirambv opened this issue Feb 21, 2024 · 1 comment · Fixed by brave/brave-core#23600
Assignees
@simoarpe
Labels
android-tablet-specific bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Network selector needs alignment

Steps to reproduce

  1. Create Wallet
  2. Open Panel and select network dropdown
  3. Network name and icon are not properly aligned and has a lot of unnecessary padding

Actual result

Tablet.Network.Selector.mp4

Expected result

More polished network selector

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): TAblet
  • Android version: 13

Brave version

1.63.157

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @simoarpe
@srirambv srirambv added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality android-tablet-specific labels Feb 21, 2024
@Douglashdaniel Douglashdaniel added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 23, 2024
@simoarpe simoarpe mentioned this issue May 13, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 14, 2024
@srirambv
Copy link
Contributor Author

Verification passed on Google Pixel 8 with Android 14 running 1.68.99 x64 Beta build

  • Verified steps from issue description
  • Verified network selector is properly aligned
image image

@hffvld hffvld mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
android-tablet-specific bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Refactor Network selector adapter brave/brave-core
4 participants
@simoarpe @srirambv @Douglashdaniel @brave-builds