Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo query set to current URL, can't be changed #36542

Closed
wknapik opened this issue Mar 4, 2024 · 7 comments · Fixed by brave/brave-core#22943
Closed

Leo query set to current URL, can't be changed #36542

wknapik opened this issue Mar 4, 2024 · 7 comments · Fixed by brave/brave-core#22943
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@wknapik
Copy link
Contributor

wknapik commented Mar 4, 2024

Description

The only Leo query possible seems to be the current URL. Querying Leo leads to a blank screen.

Steps to reproduce

  1. Type a query - Leo is not suggested image
  2. Hit enter to ask Brave Search instead image
  3. Click on the address bar, the current url is shown and the query suggested for Leo is that url
    image
  4. Hit backspace to replace the url with a query, but the suggestion remains, even after typing a new query image

Actual result

Leo should be queried for whatever the user typed and that should actually work

Expected result

Leo can only be queried about the current URL

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes (but only half the screen turns blank)
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: 16 (GrapheneOS 2024030300)

Brave version

1.63.165, Release channel

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional information

@wknapik wknapik added the OS/Android Fixes related to Android browser functionality label Mar 4, 2024
@wknapik
Copy link
Contributor Author

wknapik commented Mar 4, 2024

I'm also seeing #36145, so the blank page part of this issue might be this.

I didn't find a duplicate issue for the fixed query.

@wknapik
Copy link
Contributor Author

wknapik commented Mar 4, 2024

@wknapik
Copy link
Contributor Author

wknapik commented Mar 5, 2024

Enabling Settings -> Brave Shields & privacy -> Show autocomplete in address bar causes the Leo suggestions/queries to no longer be fixed to the current URL

@SergeyZhukovsky SergeyZhukovsky changed the title Leo query set to current URL, can't be changed, leads to a blank screen Leo query set to current URL, can't be changed Mar 5, 2024
@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Mar 5, 2024

So the issue basically due to global autocomplete settings is disabled Settings -> Brave Shields & privacy -> Show autocomplete in address bar. We should either hide Setting->Leo->Show autocomplete in address bar when the global autocomplete setting is off or perhaps better imo and what @wknapik suggested is to show it as off in Leo section and once a user tries to enable it, give a warning that this move is going to enable global autocomplete setting as well.

@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 5, 2024
@SergeyZhukovsky
Copy link
Member

cc @mattmcalister and @aguscruiz for the ideas and design

@mattmcalister
Copy link

On desktop the Leo settings have a button for Adjust autocomplete suggestions which takes you to the global settings. And then the global settings provide options for enabling/disabling autocomplete data types. That solution works well, imo. We would need a new submenu page for the Show autocomplete in address bar setting in Brave Shields & privacy, and then we could add new data types later if we wanted to, such as bookmarks and history.

image

@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 19, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Apr 4, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 2, 2024
@hffvld
Copy link
Contributor

hffvld commented May 3, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.95
Chromium: 124.0.6367.91 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from Shows Leo auto suggestions on Android regardless the global autocomplete switch brave-core#22943 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Leo's suggestion works when Show autocomplete in address bar is ON or OFF
  • Verified that Leo's suggestion is not tied up to a current URL/page

Show autocomplete in address bar is ON Show autocomplete in address bar is OFF
1 2
1 2
2024-05-02_18-04-47.mp4
2024-05-02_18-06-23.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants