Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Claude 3 Haiku (Free) and Claude 3 Sonnet (Premium) to model selection #36802

Closed
Tracked by #38195
bbondy opened this issue Mar 14, 2024 · 7 comments · Fixed by brave/brave-core#22706
Closed
Tracked by #38195
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - iPhone QA Pass-macOS QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Mar 14, 2024

We'd like to deprecate Claude Instant in favor of Claude 3 Haiku for the free tier and Claude 3 Sonnet for the premium tier.
The client should reflect the name of the model in use, and we do not need to list Haiku once the user purchases premium, we can just upgrade Haiku to Sonnet for the usage.
We may want to consider changing the default at some point to Haiku but the scope of this task is to only add support and not change the default.

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Mar 14, 2024
@bbondy bbondy changed the title Deprecate Claude Instant in favor of Claude 3 Haiku (Free) and Claude 3 Sonnet (premium) Deprecate Claude Instant in favor of Claude 3 Haiku (Free) and Claude 3 Sonnet (Premium) Mar 14, 2024
@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes browser-ai labels Mar 14, 2024
@nvonpentz nvonpentz assigned petemill and unassigned nvonpentz Mar 19, 2024
@nvonpentz
Copy link
Member

Serverside changes https://github.com/brave/aichat-ops/pull/251

@LorenzoMinto
Copy link
Member

This issue is not fully resolved by the above PR. Follow up outstanding issues:

@LorenzoMinto LorenzoMinto reopened this May 1, 2024
@LorenzoMinto LorenzoMinto changed the title Deprecate Claude Instant in favor of Claude 3 Haiku (Free) and Claude 3 Sonnet (Premium) Add Claude 3 Haiku (Free) and Claude 3 Sonnet (Premium) to model selection May 7, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2024

Closing as brave/brave-core#22706 was merged into master. As per the discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1715100595902499, iOS is currently QA/Blocked until #37989 has been resolved. CCing @Uni-verse @hffvld. So for the time being, verification for the above can only be done for Desktop & Android.

@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2024

The above requires 1.66.103 or higher for 1.66.x verification 👍

@stephendonner
Copy link

stephendonner commented May 8, 2024

Verification PASSED using

Brave | 1.66.103 Chromium: 124.0.6367.159 (Official Build) beta (x86_64)
-- | --
Revision | 74d46bb25d9ea5e6432e19f0cf38480cc372b0cf
OS | macOS Version 11.7.10 (Build 20G1427)

Shared Steps:

  1. installed 1.66.103
  2. launched Brave
  3. confirmed addition of Claude 3 Haiku and Claude 3 Sonnet (Premium) models in brave://settings/leo-assistant
  4. clicked on Leo in the sidebar
  5. confirmed addition of Claude 3 Haiku and Claude 3 Sonnet models in the Leo pane
  6. confirmed working AI-chat generated answers for Mixtral, Claude 3 Haiku, Claude Sonnet (Premium), and Llama2-13b

Confirmed working output from all models, both free and Premium

Default list

example example
Screen Shot 2024-05-08 at 10 34 48 AM Screen Shot 2024-05-08 at 10 37 06 AM

Mixtral

Screen Shot 2024-05-08 at 10 39 15 AM

Claude 3 Haiku

Screen Shot 2024-05-08 at 10 40 26 AM

Claude Sonnet (Premium)

example example example
Screen Shot 2024-05-08 at 10 41 18 AM Screen Shot 2024-05-08 at 10 44 20 AM Screen Shot 2024-05-08 at 10 45 17 AM

Llama2-13b

Screen Shot 2024-05-08 at 10 46 29 AM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS labels May 8, 2024
@stephendonner stephendonner removed QA/Test-Plan-Required QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 8, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 13, 2024
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.66.105 Chromium: 125.0.6422.41 (Official Build) (64-bit) 
Revision	ba88d7bb175a55287d14014823d5da31fe9c8a47
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that Claude 3 Haiku and Claude 3 Sonnet are shown on the list as free tier and premium tier respectively for new users.
  • Ensured that Default model for new conversation setting shows all the models in the list and Mixtral is set by default.
  • Ensured that new Claude 3 models have the correct badging for free users:
    • LIMITED badging for Haiku
    • The lock icon for Sonnet
  • Ensured that new Claude 3 models show the correct badging for premium users:
    • UNLIMITED badging for Haiku
    • `Open lock icon for Sonnet
  • Ensured that Leo defaults to Mixtral model.
  • Ensured upgrade card is shown when selecting Claude 3 Sonnet from Language models menu as well as starting new conversation when default model is set to Sonnet in settings.
  • Ensured switching language model to Haiku and hitting rate limit, upgrading to premium using IAP.
  • Ensured premium status is shown when using active credentials from account.brave.com

Defaults

Example Example Example Example Example
Screenshot 2024-05-13 at 5 03 08 PM Screenshot 2024-05-13 at 5 03 17 PM Screenshot 2024-05-13 at 5 46 58 PM Screenshot 2024-05-13 at 6 35 20 PM Screenshot 2024-05-13 at 6 39 28 PM

Premium via Active Credentials

Example Example Example Example
Screenshot 2024-05-13 at 5 28 32 PM Screenshot 2024-05-13 at 5 28 56 PM Screenshot 2024-05-13 at 5 32 54 PM Screenshot 2024-05-13 at 5 45 11 PM

Premium via IAP

Example Example Example
Screenshot 2024-05-13 at 6 42 27 PM Screenshot 2024-05-13 at 6 44 18 PM Screenshot 2024-05-13 at 6 45 19 PM

@Uni-verse Uni-verse removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 15, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented May 16, 2024

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.110

  • Ensured that Claude 3 Haiku and Claude 3 Sonnet are shown on the list as free tier and premium tier respectively for new users.
  • Ensured that Default model for new conversation setting shows all the models in the list and Mixtral is set by default.
  • Ensured that new Claude 3 models have the correct badging for free users:
    • LIMITED badging for Haiku
    • The lock icon for Sonnet
  • Ensured that new Claude 3 models show the correct badging for premium users:
    • UNLIMITED badging for Haiku
    • Open lock icon for Sonnet
  • Ensured that Leo defaults to Mixtral model.
  • Ensured upgrade card is shown when selecting Claude 3 Sonnet from Language models menu as well as starting new conversation when default model is set to Sonnet in settings. - logged Connection error when using Leo Sonnet model #38385
  • Ensured switching language model to Haiku and hitting rate limit, upgrading to premium using IAP.
  • Ensured switching to free model will enable user to continue to use chat after hitting rate limit.
  • Ensured premium status is shown when using active credentials from account.brave.com

Defaults

Example Example Example Example Example
IMG_6155 IMG_6156 IMG_6157 IMG_6186 IMG_6160

Upgrade to Premium (Active Credentials)

Example Example Example Example Example
IMG_6166 IMG_6167 IMG_6183 IMG_6184 IMG_6185

Upgrade (IAP)

Example Example Example Example Example
IMG_6187 IMG_6188 IMG_6175 IMG_6176 IMG_6177

@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - iPhone QA Pass-macOS QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants