Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Exclude LAN addresses automatically #37019

Closed
deeppandya opened this issue Mar 22, 2024 · 1 comment · Fixed by brave/brave-core#23135
Closed

[Android] Exclude LAN addresses automatically #37019

deeppandya opened this issue Mar 22, 2024 · 1 comment · Fixed by brave/brave-core#23135
Assignees
Labels
feature/vpn OS/Android Fixes related to Android browser functionality premium All issues related to Brave Premium QA Pass - Android ARM QA/Yes release-notes/include

Comments

@deeppandya
Copy link

Currently Android does not exclude LAN addresses automatically from the tunnel so by activating the VPN you end up breaking LAN access, eg. can't print, can't access things like Sonos speakers or security cameras and similar. We have a way to include the list of LAN IPs fully to resolve the issue.

@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/vpn premium All issues related to Brave Premium labels Mar 22, 2024
@deeppandya deeppandya self-assigned this Mar 27, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 1, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 4, 2024
@hffvld
Copy link
Contributor

hffvld commented Jun 4, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.023.B4 release-keys
Brave build: 1.67.100
Chromium: 125.0.6422.112 (Official Build) beta (64-bit) 

STEPS:

  1. Install and launch Brave
  2. Purchase/Activate VPN subscription
  3. Go to any website, for example, Wikipedia
  4. Three-dot menu > Share > Print
  5. Select Print service > Tap the Print button
  6. Verify that printer is available

OR

  1. Install and launch Brave
  2. Purchase/Activate VPN subscription
  3. Play YT video/music on Nest device
  4. Pull down the notification drawer on the test device with VPN enabled
  5. Verify that the player menu for the Nest device is shown and can be controlled

ACTUAL RESULTS:

  • Verified that printer is available when VPN is connected
  • Verified that cast control for the Nest devices is shown and can be controlled

Print service

2024-06-04_12-47-00.mp4

Cast control service

2024-06-04_12-49-06.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn OS/Android Fixes related to Android browser functionality premium All issues related to Brave Premium QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants