Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 123.0.6312.86 to Chromium 123.0.6312.105. #37268

Closed
mkarolin opened this issue Apr 2, 2024 · 6 comments · Fixed by brave/brave-core#22891
Closed

Upgrade from Chromium 123.0.6312.86 to Chromium 123.0.6312.105. #37268

mkarolin opened this issue Apr 2, 2024 · 6 comments · Fixed by brave/brave-core#22891
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.64.x - Release #3

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 2, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/123.0.6312.86..123.0.6312.105?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Apr 2, 2024
@mkarolin mkarolin self-assigned this Apr 2, 2024
This was referenced Apr 2, 2024
Merged
Merged
Merged
@kjozwiak kjozwiak added this to the 1.64.x - Release #3 milestone Apr 3, 2024
@kjozwiak kjozwiak closed this as completed Apr 3, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Apr 3, 2024

The above requires 1.64.116 or higher for 1.64.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.64.116 Chromium: 123.0.6312.105 (Official Build) (64-bit)
-- | --
Revision | d9090cab16ea606108bdf6edd7466df58d9d76fd
OS | Windows 10 Version 22H2 (Build 19045.4170)

image

@LaurenWags
Copy link
Member

LaurenWags commented Apr 3, 2024 •
edited
Loading

Verified with

Brave	1.64.116 Chromium: 123.0.6312.105 (Official Build) (x86_64) 
Revision	d9090cab16ea606108bdf6edd7466df58d9d76fd
OS	macOS Version 13.6.6 (Build 22G630)
Screenshot 2024-04-03 at 8 15 21 AM

Verified with

Brave	1.64.116 Chromium: 123.0.6312.105 (Official Build) (arm64) 
Revision	d9090cab16ea606108bdf6edd7466df58d9d76fd
OS	macOS Version 14.4.1 (Build 23E224)

Screenshot 2024-04-03 at 9 34 40 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.64.116 Chromium: 123.0.6312.105 (Official Build) (64-bit) 
Revision	d9090cab16ea606108bdf6edd7466df58d9d76fd
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Branding items
  • Version bump
Example Example Example
Screenshot 2024-04-03 at 9 46 21 AM Screenshot 2024-04-03 at 9 46 32 AM Screenshot 2024-04-03 at 9 46 52 AM

@btlechowski
Copy link

Verified with

Brave 1.64.116 Chromium: 123.0.6312.105 (Official Build) (64-bit)
Revision d9090cab16ea606108bdf6edd7466df58d9d76fd
OS Linux

image

@hffvld
Copy link
Contributor

hffvld commented Apr 3, 2024

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.64.116
Chromium: 123.0.6312.105 (Official Build) (64-bit)
1 2
1 2

@LaurenWags LaurenWags mentioned this issue Apr 3, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.64.x - Release #3
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 123.0.6312.86 to Chromium 123.0.6312.105. brave/brave-core
7 participants
@kjozwiak @Uni-verse @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin @hffvld