Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not getting promo ended message #3761

Closed
LaurenWags opened this issue Mar 18, 2019 · 2 comments
Closed

not getting promo ended message #3761

LaurenWags opened this issue Mar 18, 2019 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Reported via DM from community

A user sent a screenshot of a notification (on panel) from Feb which said there was a grant waiting for them. However, clicking on Claim did nothing. If the promo has run out, which I suspect is what they encountered, clicking on Claim should have given them a message like we had in browser-laptop when a promo had ended.

Steps to Reproduce

Unsure - these are just a guess

  1. Have a profile with rewards enabled
  2. When promo is available, get notification about grant on panel and brave://rewards
  3. Don't claim grant or dismiss notification
  4. Wait for promo to end.
  5. Attempt to claim grant from panel and brave://rewards.

Actual result:

Clicking on claim doesn't do anything.

Expected result:

Some kind of message notifying user that promo has ended. This is what it looked like on muon:
promo-ended-muon

Reproduces how often:

unsure

Brave version (brave://version info)

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? unsure

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Possibly related to #1793 and/or #1794 ?

@LaurenWags
Copy link
Member Author

+1 from #3382 (comment) - user was clicking on an old notification and got no indication that the promotion was no longer active. we should account for this.

@dinoboy197
Copy link

I believe I'm getting this issue as well. I have a claim button that does nothing when I click on it. Every time I launch Brave, the button comes back. Is there somewhere that I can validate that the promo for this claim has ended?

@NejcZdovc NejcZdovc removed the QA/Yes label Apr 10, 2020
@Miyayes Miyayes closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants