Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap From asset balance should not rely on persisted balance registry #37610

Closed
onyb opened this issue Apr 16, 2024 · 3 comments · Fixed by brave/brave-core#23104
Closed

Swap From asset balance should not rely on persisted balance registry #37610

onyb opened this issue Apr 16, 2024 · 3 comments · Fixed by brave/brave-core#23104
Assignees
@onyb
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release #2

Comments

@onyb
Copy link
Member

onyb commented Apr 16, 2024 •
edited
Loading

The highlighted box in the following image does not update on successful confirmation of a Swap, even after a page reload. This is because the balance is fetched from the persisted registry, which is not live. The useScopedBalanceUpdater() hook is a better choice here.

Screenshot 2024-04-16 at 07 36 12
@onyb onyb added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 16, 2024
@onyb onyb self-assigned this Apr 16, 2024
@onyb onyb mentioned this issue Apr 16, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 17, 2024
This was referenced Apr 17, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.65.116 or higher for 1.65.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.116 Chromium: 124.0.6367.60 (Official Build) (64-bit)
Revision 8727234930fb446ce6e8cf4f64a0d7234cbb1892
OS Windows 11 Version 23H2 (Build 22631.3447)
  • Verified steps from issue description
  • Verified account balance is automatically reduced when Swap confirmation happens
37610.mp4

@srirambv srirambv mentioned this issue Apr 22, 2024
Closed
@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.65.118 x64 build

  • Verified steps from issue description
  • Verified account balance is automatically reduced when Swap confirmation happens
37610.mp4

@LaurenWags LaurenWags mentioned this issue Apr 24, 2024
Closed
@hffvld hffvld mentioned this issue Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release #2
Development

Successfully merging a pull request may close this issue.

fix(wallet): use scoped balance updater in swap brave/brave-core
4 participants
@kjozwiak @onyb @srirambv @brave-builds