Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo - Add "You / Leo" name indicator besides avatar and most popular actions on the top header of every prompt/answer #37792

Closed
aguscruiz opened this issue Apr 23, 2024 · 3 comments · Fixed by brave/brave-core#23651

Comments

@aguscruiz
Copy link

aguscruiz commented Apr 23, 2024

Description

  • Addding the name of the sender at the right side of the avatar.

Also adding quick access to most common tools on each one:

  • For user: Copy / Edit / More (Shows rest of the contextual menu as it is now)
  • For Leo: Copy / Regenerate / More (Shows rest of the contextual menu as it is now)

Design example
https://www.figma.com/file/m0Gdbf0wtqyfEFGm32VLLc/Leo?type=design&node-id=3125%3A39912&mode=design&t=Xj5LubWJF0IwyjvH-1

Design system for button states:
https://www.figma.com/file/MNwi0uwXNhkAbPiJ86G4vm/%E2%9C%A8-Leo?type=design&node-id=1506%3A8040&mode=design&t=MzAuxvpPR619wmZL-1

Expected result:

image

image

@LaurenWags
Copy link
Member

@nullhook @rebron can one of you add the following labels as necessary:

  • release-notes/exclude or release-notes/include

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 10, 2024

Verification PASSED using

Brave | 1.68.84 Chromium: 126.0.6478.40 (Official Build) beta (64-bit)
-- | --
Revision | c5a3b2ff9dcc938c32b2c1b3a66847661db5d005
OS | Windows 11 Version 23H2 (Build 22631.3672)
  1. Installed 1.68.84
  2. launched Brave
  3. opened account.bravesoftware.com
  4. logged in as a Leo premium user
  5. clicked Leo icon on the sidebar to open Leo side panel
  6. opened bbc.com in a new tab
  7. accepted agreement and summarized the page
  • Confirmed You is shown next the avatar in the side panel
  • Confirmed Leo next to Leo icon in the side panel
  • Confirmed Copy icon is shown for Leo
  • Confirmed vertical 3 dot menu shown for Leo icon with Like answer and Dislike answer
example example
image image

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.68.115

  • Confirmed You is shown next the avatar in the side panel
  • Confirmed Leo next to Leo icon in the side panel
  • Confirmed Copy icon is shown for Leo
  • Confirmed vertical 3 dot menu shown for Leo icon with Like answer and Dislike answer

Non premium user:

Example Example
Screenshot_20240711_154647 Screenshot_20240711_154730

Premium user:

Example Example
Screenshot_20240711_160304 Screenshot_20240711_160309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants