-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default theme should be dark or light depending on Windows 10 preference #3804
Comments
This is expected behavior for now because upstream disabled dark theme support on Win10. |
@btlechowski have you checked with setting apps colour? By default the app is set to light always. |
@srirambv @btlechowski We don't need to test theme on Windows for now. |
@btlechowski We can test |
@simonhong was this upstreamed in one of the C74 bumps? |
@kjozwiak beta(C74) has |
Verification passed on
Verified test plan from brave/brave-core#2352 and from the description. Checked changing Same as Windows(Dark)->Same as Windows(Light) and Same as Windows(Light)->Same as Windows(Dark). Checked settings dropdown, permissions alert box (notifications, geolocation, translations, alerts) and downloads bar. |
Follow up to #1189
This feature has been implemented on MacOS, but Windows version had some problems and is hidden behind a flag. brave/brave-core#1805 (review)
Steps to Reproduce
Actual result:
There is no
Same as Windows
inBrave colors
Expected result:
Same as Windows
is available inBrave colors
Same as Windows
is the default option on Windows 10Reproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @brave/legacy_qa @petemill @simonhong
The text was updated successfully, but these errors were encountered: