Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Highlight discount Text in Vpn paywall #38239

Closed
deeppandya opened this issue May 10, 2024 · 2 comments · Fixed by brave/brave-core#23580
Closed

[Android] Highlight discount Text in Vpn paywall #38239

deeppandya opened this issue May 10, 2024 · 2 comments · Fixed by brave/brave-core#23580
Assignees
@deeppandya
Labels
feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@deeppandya
Copy link

With this issue, we need to update renew annually save X% text with save X% bold and underlined.
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 10, 2024
@deeppandya deeppandya self-assigned this May 10, 2024
@deeppandya
Copy link
Author

Screenshot_2024-05-10-16-27-34-20_82cebf612ef3f9a8762672c971adaed4

@deeppandya deeppandya mentioned this issue May 10, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 13, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 11, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP31.240517.031 release-keys
Brave build: 1.68.115
Chromium: 127.0.6533.26 (Official Build) beta (64-bit)

STEPS:

  1. Launch Brave
  2. Hamburger menu > Brave VPN > Verify

ACTUAL RESULTS:

  • Verified that the string says "Renew annually save 17%"
Old New
1 2

@hffvld hffvld mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

Highlight discount text brave/brave-core
4 participants
@kjozwiak @deeppandya @brave-builds @hffvld