Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIWE failed in tally.xyz #38878

Closed
3 of 6 tasks
darkdh opened this issue Jun 6, 2024 · 3 comments · Fixed by brave/brave-core#24051
Closed
3 of 6 tasks

SIWE failed in tally.xyz #38878

darkdh opened this issue Jun 6, 2024 · 3 comments · Fixed by brave/brave-core#24051

Comments

@darkdh
Copy link
Member

darkdh commented Jun 6, 2024

Description

We added addition uri check which is not specified in eip-4361 and it failed in the case of tally sign in.
https://bravesoftware.slack.com/archives/CBP2ZKC0H/p1717697713982729?thread_ts=1717689824.083089&cid=CBP2ZKC0H

Steps to reproduce

  1. Navigate to https://www.tally.xyz/gov/wormhole
  2. Click "Connect" and approve
  3. Click "Sign in"

Actual result

Screenshot 2024-06-06 at 11 40 07

Expected result

There should be no errors.

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

Brave 1.68.61 Chromium: 126.0.6478.26 (Official Build) nightly (x86_64)
Revision 33acf8f3b22f4ec9f640dc46911d4a9ea15654af
OS macOS Version 14.5 (Build 23F79)

Android device

device info is not relevant

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.68.92 or higher for 1.68.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.68.92 Chromium: 126.0.6478.71 (Official Build) beta (64-bit)
Revision 393b9968e233540a48f04d74bc4601a05d3a0169
OS Windows 11 Version 23H2 (Build 22631.3737)
  • Verified steps from issue description
  • Verified able to sign and connect on https://passport.gitcoin.co/
  • Verified able to sign and connect on https://www.tally.xyz/gov/wormhole
34470.mp4

@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.68.99 x64 Beta build

  • Verified steps from issue description
  • Verified able to sign and connect on https://passport.gitcoin.co/
  • Verified able to sign and connect on https://www.tally.xyz/gov/wormhole
38878.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants