Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding text overlaps on one another #38912

Closed
3 of 6 tasks
srirambv opened this issue Jun 10, 2024 · 1 comment · Fixed by brave/brave-core#24063
Closed
3 of 6 tasks

Onboarding text overlaps on one another #38912

srirambv opened this issue Jun 10, 2024 · 1 comment · Fixed by brave/brave-core#24063
Assignees
@simoarpe
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Onboarding text overlaps on one another

Steps to reproduce

  1. Clean install browser
  2. Open Wallet from menu
  3. Onboarding screen has text overlapping on one another

Actual result

image

Expected result

No overlapping text

Reproduces how often

Easily reproduced

Brave version

All

Device

  • Brand/model: All
  • Android version: All

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @simoarpe
@srirambv srirambv added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 10, 2024
@simoarpe simoarpe self-assigned this Jun 10, 2024
@simoarpe simoarpe mentioned this issue Jun 10, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 12, 2024
@srirambv
Copy link
Contributor Author

Verification passed on Google Pixel 8 with Android 14 running 1.69.147 x64 build

  • Verified steps from issue description
  • Verified Onboarding text has proper padding
Google Pixel 8 (Android 14) Lenovo Tab (Android 13)
image image

@kjozwiak kjozwiak mentioned this issue Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Tweak onboarding layouts and styles following updated Figma design brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds