Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new confirmation screen when finishing onboarding #39348

Closed
simoarpe opened this issue Jun 25, 2024 · 1 comment · Fixed by brave/brave-core#24424
Closed

Implement new confirmation screen when finishing onboarding #39348

simoarpe opened this issue Jun 25, 2024 · 1 comment · Fixed by brave/brave-core#24424
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Jun 25, 2024 •
edited
Loading

Description

Implement new confirmation screen that will be shown to the user at the end of onboarding process.

Light Theme Dark Theme
Screenshot from 2024-06-25 13-14-49 Screenshot from 2024-06-25 13-14-17

⚠️ Note: Once available, replace main illustration with a version containing color reference #39423

🎨 Figma design: https://www.figma.com/file/oXIiv45pIhF2RGlpEjOfUg/Wallet-onboarding?node-id=6223%3A70942&mode=dev

☂ Main umbrella issue: #35294
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 25, 2024
@simoarpe simoarpe self-assigned this Jun 25, 2024
This was referenced Jun 25, 2024
Closed
Open
Merged
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 1, 2024
@srirambv
Copy link
Contributor

srirambv commented Jul 22, 2024 •
edited
Loading

Verification passed on Google Pixel 8 with Android 14 running 1.69.121 x64 Beta build

  • Verified steps from brave/brave-core#24424
  • Verified new confirmation screen is shown when finishing onboarding when creating new wallet
  • Verified new confirmation screen is shown when finishing onboarding when restoring wallet
  • Verified new confirmation screen is not shown when completing back from a newly created wallet
  • Encountered #39608 (comment)
Light Dark
image image

@kjozwiak kjozwiak mentioned this issue Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Implement new confirmation screen when finishing onboarding brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds