-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove suggested top sites on first start on Android #39541
Labels
enhancement
OS/Android
Fixes related to Android browser functionality
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass - Android ARM
QA Pass - Android Tab
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
anthonypkeane
added
needs-more-info
The report requires more detail before we can decide what to do with this issue.
OS/Android
Fixes related to Android browser functionality
labels
Jul 3, 2024
We actually want to remove pre-defined fav icons for now to avoid pings to thrid parties on initial start. |
SergeyZhukovsky
changed the title
Android NTP favicons update
Remove suggested top sites on first start on Android
Jul 4, 2024
24 tasks
SergeyZhukovsky
added
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/include
enhancement
and removed
needs-more-info
The report requires more detail before we can decide what to do with this issue.
labels
Jul 4, 2024
bsclifton
added
QA/Test-Plan-Specified
priority/P2
A bad problem. We might uplift this to the next planned release.
and removed
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Jul 8, 2024
7 tasks
The above requires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
OS/Android
Fixes related to Android browser functionality
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass - Android ARM
QA Pass - Android Tab
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Test plan
See brave/brave-core#24511
Description
Slack Discussion: https://bravesoftware.slack.com/archives/C0816QH3R/p1720038297944829?thread_ts=1719641904.987839&cid=C0816QH3R
Follow up to https://github.com/brave/reviews/issues/1678#issuecomment-2204676303
Please update the logic on the Android NTP favicons to follow iOS.
On iOS, we have a set of bundled favicons that are shown initially. When the user first visits one of those websites, we pull in the favicon from the website.
The text was updated successfully, but these errors were encountered: