Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suggested top sites on first start on Android #39541

Closed
anthonypkeane opened this issue Jul 3, 2024 · 3 comments · Fixed by brave/brave-core#24511
Closed

Remove suggested top sites on first start on Android #39541

anthonypkeane opened this issue Jul 3, 2024 · 3 comments · Fixed by brave/brave-core#24511
Assignees
Labels

Comments

@anthonypkeane
Copy link

anthonypkeane commented Jul 3, 2024

Test plan

See brave/brave-core#24511

Description

Slack Discussion: https://bravesoftware.slack.com/archives/C0816QH3R/p1720038297944829?thread_ts=1719641904.987839&cid=C0816QH3R

Follow up to https://github.com/brave/reviews/issues/1678#issuecomment-2204676303

Please update the logic on the Android NTP favicons to follow iOS.

On iOS, we have a set of bundled favicons that are shown initially. When the user first visits one of those websites, we pull in the favicon from the website.

@anthonypkeane anthonypkeane added needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality labels Jul 3, 2024
@SergeyZhukovsky
Copy link
Member

We actually want to remove pre-defined fav icons for now to avoid pings to thrid parties on initial start.

@SergeyZhukovsky SergeyZhukovsky self-assigned this Jul 4, 2024
@SergeyZhukovsky SergeyZhukovsky changed the title Android NTP favicons update Remove suggested top sites on first start on Android Jul 4, 2024
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include enhancement and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Jul 4, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 5, 2024
@bsclifton bsclifton added QA/Test-Plan-Specified priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 8, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jul 16, 2024

The above requires 1.68.123 or higher for 1.68.x verification 👍 @hffvld @Uni-verse can use brave/brave-core#24511 (comment) as a template for 1.68.x verification. But we should check both mobile & tablet as well.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 19, 2024

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.68.125 Chromium: 127.0.6533.57 (Official Build) (64-bit)
--- | ---
Revision | 14ff4d467fb3eec4e6fc0a2f3e2d3f7b4c8cb788
OS | Android 15; Build/AP31.240517.031; 35; REL
  • ensured that the pre-determined websites based on region are not being populated via NTP on first launch
  • ensured that there's no websites being displayed/being loaded when opening several NTP
  • ensured that there's no connections to websites like bestbuy.com, facebook.com & amazon.com via Proxyman
  • ensured that once you start visiting several websites, the most popular/visited ones get loaded into Favorites
  • upgraded from 1.67.123 Chromium: 126.0.6478.126 -> 1.68.125 Chromium: 127.0.6533.57 and ensured that the previous Favorites under NTP weren't affected after upgrading

Also checked the following scenario to ensure that Favorites are still being added into the NTP:

  • download/install 1.67.123 Chromium: 126.0.6478.126 and notice the pre-populated Favorites on the second NTP
  • upgrade to 1.68.125 Chromium: 127.0.6533.57 and notice that all the pre-populated Favorites have been removed
  • visited several websites ~3-4 times each and ensured that the website was added into Favorites under NTP

Also ensured that previous Favorites that have been added by the user are not removed/affected after upgrading.

Example Example Example Example
Screenshot 2024-07-19 at 4 07 40 PM Screenshot_20240719-160726 Screenshot_20240719-160731 Screenshot_20240719-161213

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 14 using the following build(s):

Brave | 1.68.125 Chromium: 127.0.6533.57 (Official Build) (64-bit)
--- | ---
Revision | 14ff4d467fb3eec4e6fc0a2f3e2d3f7b4c8cb788
OS | Android 14; Build/UP1A.231005.007; 34; REL
  • ensured that the pre-determined websites based on region are not being populated via NTP on first launch
  • ensured that there's no websites being displayed/being loaded when opening several NTP
  • ensured that there's no connections to websites like bestbuy.com, facebook.com & amazon.com via Proxyman
  • ensured that once you start visiting several websites, the most popular/visited ones get loaded into Favorites
  • upgraded from 1.67.123 Chromium: 126.0.6478.126 -> 1.68.125 Chromium: 127.0.6533.57 and ensured that the previous Favorites under NTP weren't affected after upgrading

Also checked the following scenario to ensure that Favorites are still being added into the NTP:

  • download/install 1.67.123 Chromium: 126.0.6478.126 and notice the pre-populated Favorites on the second NTP
  • upgrade to 1.68.125 Chromium: 127.0.6533.57 and notice that all the pre-populated Favorites have been removed
  • visited several websites ~3-4 times each and ensured that the website was added into Favorites under NTP

Also ensured that previous Favorites that have been added by the user are not removed/affected after upgrading.

Example Example Example Example
Screenshot 2024-07-19 at 4 39 43 PM Screenshot_20240719_164052_Brave Screenshot_20240719_164510_Brave Screenshot_20240719_164055_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done/Closed
Development

Successfully merging a pull request may close this issue.

5 participants