Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Resolve billing client issues #40078

Closed
3 of 6 tasks
deeppandya opened this issue Jul 29, 2024 · 2 comments · Fixed by brave/brave-core#24891
Closed
3 of 6 tasks

[Android] Resolve billing client issues #40078

deeppandya opened this issue Jul 29, 2024 · 2 comments · Fixed by brave/brave-core#24891
Assignees

Comments

@deeppandya
Copy link

Description

With new gmail account, we are getting the error shown below in the screenshot,

Steps to reproduce

  1. Create a new gmail account
  2. Try to purchase the subscription through IAP

Actual result

Screenshot_20240727-091544

Expected result

No error

Reproduces how often

Easily reproduced

Brave version

1.68.x and newer

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

For QA: billing library was affected, so we should double check nothing regressed in this regard (like subscribing to VPN, Leo and so on).

  • create a brand new GPS account/get the email account added to the internal test and verify that purchase VPN works
  • install Brave on a previous GPS account that already had a subscription in the past and make sure that's working
  • upgrade from the previous version where you already have a subscription and ensure your subscription still works
@kjozwiak
Copy link
Member

kjozwiak commented Jul 30, 2024

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.68.133 Chromium: 127.0.6533.73 (Official Build) (64-bit)
--- | ---
Revision | 4b666a378f83d73216bfe91260f1d335d4787b38
OS | Android 15; Build/AP31.240617.009; 35; REL

Test Case #1 - New GPS Account (has never subscribed to premium)

  • created a brand new Google account and @deeppandya added it into the GPS internal beta channel
  • verified that the new account had access to 1.68.133 Chromium: 127.0.6533.73 via the internal test channel
  • downloaded/launched 1.68.133 Chromium: 127.0.6533.73
  • tapped on the Hamburger Menu -> VPN -> 7 Day Free Trial
  • ensured that the purchase card was being displayed without any issues
  • ensured that you can run through the Billing API and subscribe/enable VPN
Example Example Example Example Example Example Example
1000001820 1000001822 1000001823 1000001824 1000001825 1000001826 1000001827

Test Case #2 - Using previous/older account (has subscribed to Premium before)

  • download/installed 1.68.128 Chromium 127.0.6533.73 which @deeppandya provided
    • Quick Note: this APK was signed with a different key to allow IAP using an APK
  • upgraded from 1.68.128 Chromium 127.0.6533.73 --> 1.68.133 Chromium: 127.0.6533.73 via the internal test channel
  • tapped on the Hamburger Menu -> VPN -> 7 Day Free Trial
  • ensured that the purchase card was being displayed without any issues

Screenshot_20240730-114106

@hffvld
Copy link
Contributor

hffvld commented Jul 30, 2024

Verified on Pixel 6 using version(s):

Device/OS: Pixel 6 / oriole-user 14 AP2A.240605.024 release-keys
Brave build: 1.68.133
Chromium: 127.0.6533.73 (Official Build) (64-bit)

New Google account

STEPS:

  1. Create a brand new @gmail.com account > Sign in with that account on a test device
  2. Install Brave 1.68.133 from Play Store
  3. Launch Brave > Attempt to purchase VPN or Leo subscription
  4. Finish purchase flow > Verify

ACTUAL RESULTS:

  • Verified that a brand new account can purchase VPN and Leo subscriptions from Play Store
  • Verified

1 2 3
1 2 3
1 2 3
1 2 3
Account which already subscribed in the past

STEPS:

  1. Install Brave 1.68.128 from Play Store
  2. Launch Brave > Attempt to purchase Leo or VPN subscription > Confirm the error
  3. Install Brave 1.68.133
  4. Launch Brave > Attempt to purchase Leo or VPN subscription > Confirm there is no error

ACTUAL RESULTS:

  • Verified that accounts that made a purchase in the past are still able to purchase VPN and Leo subscriptions from the Play Store
  • Verified that it says You're not eligible for the free trial

1 2
1 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants