Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Browser CPU regression in SafeBrowsing::VerifyChecksum after cr130 #41681

Closed
atuchin-m opened this issue Oct 16, 2024 · 3 comments · Fixed by brave/brave-core#26191
Closed

[Perf] Browser CPU regression in SafeBrowsing::VerifyChecksum after cr130 #41681

atuchin-m opened this issue Oct 16, 2024 · 3 comments · Fixed by brave/brave-core#26191
Assignees
@atuchin-m
Labels
OS/Desktop perf perf-regression An perf browser issue by the perf dashboard priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Milestone
1.71.x - Release #3

Comments

@atuchin-m
Copy link
Contributor 

Alert information:
Median of segment before: 949.8530000000001
Median of segment after: 1413.136
Relative change: 48.8%
Test: BravePerf/mac-mini-m1-typical/system_health.common_desktop/cpuTime:all_processes:all_threads:all_stages:all_initiators/load_chrome/load_chrome_blank
  • All the desktop platform are affected
  • Chromium builds also have the same issue.
  • Chromium revision range: 129.0.6668.89 - 130.0.6723.31
@atuchin-m atuchin-m added OS/Android Fixes related to Android browser functionality OS/Desktop perf perf-regression An perf browser issue by the perf dashboard labels Oct 16, 2024
@atuchin-m
Copy link
Contributor Author

cr129/cr130:
Image

@atuchin-m atuchin-m removed the OS/Android Fixes related to Android browser functionality label Oct 17, 2024
@atuchin-m
Copy link
Contributor Author

An upstream issue with steps to verify: https://crbug.com/373928217

@rebron rebron added this to Perf Oct 17, 2024
@github-project-automation github-project-automation bot moved this to To do in Perf Oct 17, 2024
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include labels Oct 18, 2024
@atuchin-m atuchin-m mentioned this issue Oct 24, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from To do to Done in Perf Oct 24, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 24, 2024
This was referenced Oct 24, 2024
Merged
Merged
@atuchin-m atuchin-m self-assigned this Oct 24, 2024
@atuchin-m
Copy link
Contributor Author

atuchin-m commented Oct 25, 2024 •
edited
Loading

The issue is resolved for v1.73.44 for all the affected platforms:

@LaurenWags LaurenWags mentioned this issue Oct 30, 2024
Closed
@0901061540 0901061540 mentioned this issue Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
OS/Desktop perf perf-regression An perf browser issue by the perf dashboard priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
Perf
Status: Done
Milestone
1.71.x - Release #3
Development

Successfully merging a pull request may close this issue.

Backport https://crrev.com/c/5955393 brave/brave-core
3 participants
@rebron @brave-builds @atuchin-m