Verified pubs image is not displayed

[GeetaSarvadnya]

Description

Verified pubs image is not displayed in BR panel

Steps to Reproduce

1. Enable rewards on 0.67.14
2. Upgrade to 0.67.55
3. Open verified twitter pubs in new tab
4. Click on BR panel

Actual result:

Verified pubs image is not displayed in BR panel

Verified pubs image is not displayed in the rewards banner

Verified pubs image is not displayed in the Tips panel

Expected result:

verified pubs image should be displayed in BR panel

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly (64-bit)
Revision	3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS	Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? NA
• Can you reproduce this issue with the dev channel? NA
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc : @brave/legacy_qa @NejcZdovc

[LaurenWags]

I was able to reproduce this in the following way:

1. Install Nightly, Enable Rewards.
2. Navigate to twitter page for user who is not yet verified. (I used myself)
3. I verified my twitter acct, and waited a few hours. Later, I clicked on 'check again...'.
4. When the publisher list which contained my acct was pulled, I got my verified check mark but not my favicon - I still see the generic twitter one. Even after refreshing the page, opening a new tab and navigating again - I still retain the generic twitter favicon on panel and brave://rewards page.
   Note - @kjozwiak was already verified when I first installed the build and got my list - so I see his favicon instead of the generic one.
   
   

[NejcZdovc]

@GeetaSarvadnya could you reproduce this one clean profile? I think this one only happens if publisher is already in the database and then they become verified

[NejcZdovc]

Problem with this one is that once site is in the DB we don't try to pull publisher image. What we need to do here is check if verified status changed and if so we need to pull the image

[GeetaSarvadnya]

@NejcZdovc On the clean/upgraded profile, it works fine now I am unable to reproduce the issue in 0.69.128

[GeetaSarvadnya]

The issue is still reproducible in Windows 10 x64 -1.16.x

Brave | 1.16.23 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
-- | --
Revision | 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

[LaurenWags]

Verified passed with

Brave | 1.17.34 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified that on a clean profile with 1.17.x the verified Twitter publisher's favicon displays in the panel if the publisher does not have a custom favicon:

If the verified Twitter publisher has a custom favicon for their tipping banner, that displays in the panel instead of the Twitter favicon. Per internal discussions this is expected.

Confirmed non-verified Twitter publishers still show generic Twitter icon:

Also, if you experienced this issue prior to 1.17.x, meaning you visited a verified Twitter publisher with 1.16.x or before, you will still see the generic twitter icon in the panel as the panel cache does not expire. Per internal discussions this will be resolved with #6059:

---

Verification passed on

Brave | 1.17.42 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified that on a clean profile with 1.17.x the verified Twitter publisher's favicon displays in the panel if the publisher does not have a custom favicon:

If the verified Twitter publisher has a custom favicon for their tipping banner, that displays in the panel instead of the Twitter favicon. Per internal discussions, this is expected.

Confirmed non-verified Twitter publishers still show generic Twitter icon:

Installed 1.15.x and visited verified twitter pubs (observed generic twitter favicon display in Panel) and upgraded profile to 1.17.x generic favicon has still remained. As per the above comments from @LaurenWags, the issue will be fixed with #6059:

1.15.x and upgrade to 1.17.x

Verified passed with

Brave	1.17.34 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
Revision	002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS	Ubuntu 18.04 LTS

Verified that on a clean profile with 1.17.x the verified Twitter publisher's favicon displays in the panel if the publisher does not have a custom favicon:

If the verified Twitter publisher has a custom favicon for their tipping banner, that displays in the panel instead of the Twitter favicon. Per internal discussions this is expected.

Confirmed non-verified Twitter publishers still show generic Twitter icon:

---