Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webusb support #4669

Closed
mrose17 opened this issue May 31, 2019 · 3 comments · Fixed by brave/brave-core#2574
Closed

webusb support #4669

mrose17 opened this issue May 31, 2019 · 3 comments · Fixed by brave/brave-core#2574

Comments

@mrose17
Copy link
Member

mrose17 commented May 31, 2019

Test Case:

Original Issue

sadly, webusb appears to be table stakes...

Description

The browser does not support webusb.

Steps to Reproduce

  1. Connect to a service that requires webusb, e.g., beta.shapeshift.com
  2. Attempt to pair your KeepKey

Actual result:

Screen Shot 2019-05-31 at 14 00 16

Expected result:

Success

Reproduces how often:

100%

Brave version (brave://version info)

Version 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)```

## Version/Channel Information:
- Can you reproduce this issue with the current release? yes
- Can you reproduce this issue with the beta channel? yes
- Can you reproduce this issue with the dev channel? yes
- Can you reproduce this issue with the nightly channel? yes

## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? yes
- Does the issue resolve itself when disabling Brave Rewards? yes
- Is the issue reproducible on the latest version of Chrome? no, it supports webusb

## Miscellaneous Information:
None.
@bbondy bbondy added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jun 1, 2019
@simonhong simonhong self-assigned this Jun 1, 2019
@simonhong simonhong added this to the 0.68.x - Nightly milestone Jun 3, 2019
@simonhong
Copy link
Member

Brave returns undefined for navigator.usb.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 10, 2019

Similar findings under #3120 (comment) when investigated why Trezor wasn't working. Will close off #3120 once this has been verified. You would receive the following error:

iframe.9b57ae6d349fd314f512.js:8 [trezor-link] Error in WebUsbPlugin.init Error: WebUSB is not available on this browser.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 13, 2019

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X

Screen Shot 2019-06-12 at 11 24 27 PM

Screen Shot 2019-06-12 at 11 30 09 PM

Screen Shot 2019-06-12 at 11 30 54 PM

Verification passed on

Brave 0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

image

Verification passed on

Brave 0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified navigator.usb didn't retrun undefined
    image (1)

  • Verified Trezor worked on mycrypto.com

  • Verified Trezor worked with wallet.trezor.com
    image

  • Verified Ledger Nano S worked with mycrypto.com
    image (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants