Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification badge is retained even after closing the notification in BR Panel #4759

Closed
srirambv opened this issue Jun 7, 2019 · 12 comments
Closed
Labels
feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. QA/Yes regression

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 7, 2019

Description

Notification badge is retained even after closing the notification in BR Panel

Steps to Reproduce

  1. Keep using the profile
  2. Wait for the notifications to show up
  3. Open BR panel and dismiss notification, badge is still retained even though actual notification is closed

Actual result:

Screenshot 2019-06-07 at 5 25 55 PM

Expected result:

Notification badge should be removed when actual notification is closed

Reproduces how often:

You have to be lucky to see this or reproduce this

Brave version (brave://version info)

Brave 0.67.73 Chromium: 75.0.3770.38 (Official Build) dev(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X / Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes. Seen it on Linux
  • Can you reproduce this issue with the dev channel? Yes, seen it on both macOS and Linux
  • Can you reproduce this issue with the nightly channel? Yes but not used it on both OS

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N.A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

#4731 could be related. But I have seen the issue on Linux and macOS without having to put the device to sleep.

@NejcZdovc
Copy link
Contributor

@srirambv could you please provide more info.

Tried this steps and it's working correctly:

  • clean profile
  • enable rewards through settings page
  • open panel
  • close grant notification
  • notification is dismissed

@NejcZdovc NejcZdovc added needs-more-info The report requires more detail before we can decide what to do with this issue. and removed bug labels Jun 10, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Jun 10, 2019

@NejcZdovc mine wasn't a clean profile. It was an existing profile that I have been using for quite sometime. I've been using the profile on Linux since April. This is what is shown on brave://local-state/ for
Linux
image

macOS
image

I doubt it happens on a clean install you will have to have a decent browsing profile updating from multiple versions I guess. I do think this is a bug because its happening on both macOS and Linux for existing profiles that update over a period of time.

@srirambv
Copy link
Contributor Author

Btw I forgot to mention it in the steps, the notifications that I received were for Ads grant and backup wallet notification on both profiles.

@NejcZdovc
Copy link
Contributor

@srirambv if you reopen the panel are notifications back so you could dismiss it again?

@srirambv
Copy link
Contributor Author

@NejcZdovc nope. Close and reopen browser fixed it. Even switching between tabs had not fixed that as far as I can remember

@NejcZdovc
Copy link
Contributor

@srirambv when you say fixed it, are they gone now?

@srirambv
Copy link
Contributor Author

Yes there is no notification badge after restart. But while the browser was active I did have the notification badge remain even after manually closing the notification in the panel

@bsclifton
Copy link
Member

bsclifton commented Jun 10, 2019

I have this problem- it's always stuck at 29 for me ☹️ Not sure if there's a way to clear (restarts don't help. Has been this way since fixing the bug where the button didn't work). Shoot me a message if you'd like me to share profile details 😄

@srirambv
Copy link
Contributor Author

@NejcZdovc i just saw this on Linux again. Switching tab fixes the notification badge. So that particular tab doesn't remove the badge once notifications are closed

@srirambv
Copy link
Contributor Author

@NejcZdovc here's a recording of the issue to make it more clear.
https://youtu.be/JPGSdyia4fQ

@NejcZdovc
Copy link
Contributor

@srirambv is this still a problem?

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 3, 2022

Closing as stale. Can file anew if we still observe this. There are some other issues already filed regarding notification badges too.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. QA/Yes regression
Projects
None yet
Development

No branches or pull requests

4 participants