Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ads should only be sustained after the page has fully loaded #4798

Closed
tmancey opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2658
Closed

Fix ads should only be sustained after the page has fully loaded #4798

tmancey opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2658

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 11, 2019

Description

Fix Ads should only be sustained after the page has fully loaded

Steps to Reproduce

  1. View an Ad

Actual result:

Ad is sustained 10 seconds after page starts to load

Expected result:

Ad should be sustained 10 seconds after page has fully loaded

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@tmancey tmancey added this to the 0.68.x - Nightly milestone Jun 11, 2019
@tmancey tmancey self-assigned this Jun 11, 2019
@tmancey tmancey added QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. and removed pr/pending-review labels Jun 11, 2019
@tmancey tmancey changed the title Fix Ads should only be sustained after the page has fully loaded Fix ads should only be sustained after the page has fully loaded Jun 11, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 5, 2019

Verification passed on

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

image

Verified passed with

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants