Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent: UI Redesign #5402

Open
feross opened this issue Jul 26, 2019 · 4 comments
Open

WebTorrent: UI Redesign #5402

feross opened this issue Jul 26, 2019 · 4 comments
Assignees
Labels
design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues

Comments

@feross
Copy link

feross commented Jul 26, 2019

This issue is for discussing a UI redesign for the WebTorrent extension. @rossmoody did some amazing work on some mockups in this comment: brave/brave-core#3003 (comment) which are a great starting point.

Goals

  • Modernize and cleanup the design
  • Show better indicators of download progress (including individual file progress)
  • Offer "Save All Files..." functionality (WebTorrent: Add "Save All Files..." feature #1230)
  • Indicate which files are viewable/playable immediately in the browser (play icon?)
  • Any other goals?
@feross feross added design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues labels Jul 26, 2019
@rossmoody
Copy link
Contributor

Depending how much we want to break this down per issues (and I would defer but I'd like to help where i can) I think if we use the following screens as a baseline then maybe something like:

  • Refine UI structure and style (larger initial restructure with tbd subtasks like new components and sunset Brave UI dependencies)
  • Component states, responsiveness and accessibility refinement
  • Set up theming variables
  • Hook up theming to Brave theme provider
  • Show better indicators of download progress (including individual file progress)
  • Offer "Save All Files..." functionality (WebTorrent: Add "Save All Files..." feature #1230)
  • Indicate which files are viewable/playable immediately in the browser (play icon?)
  • Open in new tab button (for media of tbd type)
  • Indicate a disabled version of media buttons until content is ready

image

image

@rebron
Copy link
Collaborator

rebron commented Jul 29, 2019

I suspect long file names will be the usual and we'll see wrapping more often than not. Maybe wider on the filename? Design looks really nice.

@rossmoody
Copy link
Contributor

that's so true. maybe some type of character limit and then institute truncation? could be a nice accessibility feature to fill the title attr of the truncated text with some type of automation.

Screen Shot 2019-07-29 at 5 01 21 PM

@feross
Copy link
Author

feross commented Aug 7, 2019

I implemented the design in HTML + CSS ✨ It looks great!

Click to zoom. 🔎

Screen Shot 2019-08-07 at 4 10 59 PM
Screen Shot 2019-08-07 at 4 10 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues
Projects
None yet
Development

No branches or pull requests

3 participants