Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing about brave icon under "brave://settings" so it matches correct channel #5443

Closed
kjozwiak opened this issue Jul 30, 2019 · 1 comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team feature/settings misc/icons priority/P4 Planned work. We expect to get to it "soon".

Comments

@kjozwiak
Copy link
Member

Description

We should change the Brave icon that's displayed at the bottom left corner next to About under brave://settings/ so it matches the correct channel.

Steps to Reproduce

  1. open a nightly or a dev version of Brave
  2. visit brave://settings/ and you'll notice that the Brave icon next to About is the official icon which is used for the release channel

Actual result:

Screen Shot 2019-07-29 at 11 17 03 PM

Screen Shot 2019-07-29 at 11 31 55 PM

Expected result:

Probably a good idea to use the correct channel icon rather than the official release icon

Reproduces how often:

100% reproducible using the above STR

Brave version (brave://version info)

Brave 0.70.9 Chromium: 76.0.3809.72 (Official Build) nightly (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Mac OS X
Brave 0.69.95 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@kjozwiak kjozwiak added design A design change, especially one which needs input from the design team misc/icons feature/settings labels Jul 30, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 9, 2019
@bsclifton
Copy link
Member

This has been fixed at some point 😄

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team feature/settings misc/icons priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

3 participants