Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge adblock engines #5461

Closed
antonok-edm opened this issue Jul 30, 2019 · 1 comment · Fixed by brave/brave-core#16340
Closed

Merge adblock engines #5461

antonok-edm opened this issue Jul 30, 2019 · 1 comment · Fixed by brave/brave-core#16340
Assignees
@antonok-edm
Labels
dev-concern feature/shields/adblock Blocking ads & trackers with Shields feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Milestone
1.48.x - Release

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Jul 30, 2019 •
edited
Loading

Brave creates at least two separate instances of the adblock-rs adblocking engine, separately managing base rules (e.g. easylist, easyprivacy), custom user-added rules, and an additional engine for each regional list or subscription list.

Separate instances cannot benefit from the performance optimizations of adblock-rs; each engine must be checked serially for matches or exceptions and the results must be combined afterwards.

The three different adblock service managers were implemented separately to allow for independent state management. This functionality will need to effectively be moved into adblock-rs.
@pes10k pes10k added feature/shields The overall Shields feature in Brave. feature/shields/adblock Blocking ads & trackers with Shields perf labels Jul 30, 2019
@antonok-edm antonok-edm mentioned this issue Aug 18, 2020
Merged
32 tasks
@antonok-edm antonok-edm mentioned this issue Sep 4, 2020
Closed
@antonok-edm antonok-edm mentioned this issue Jan 25, 2021
Merged
23 tasks
@antonok-edm antonok-edm mentioned this issue Sep 13, 2022
Closed
@antonok-edm antonok-edm mentioned this issue Oct 26, 2022
Closed
@antonok-edm antonok-edm mentioned this issue Nov 17, 2022
Merged
25 tasks
@iefremov
Copy link
Contributor

cc @atuchin-m

@antonok-edm antonok-edm mentioned this issue Dec 12, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Jan 3, 2023
@bridiver bridiver added OS/Desktop OS/Android Fixes related to Android browser functionality labels Jan 4, 2023
@antonok-edm antonok-edm mentioned this issue Jan 9, 2023
Closed
@ghost ghost mentioned this issue Mar 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
dev-concern feature/shields/adblock Blocking ads & trackers with Shields feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

The Great Adblock Engine Merge brave/brave-core
6 participants
@bridiver @pes10k @iefremov @rebron @antonok-edm @brave-builds