Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] Restricted flag should be set to yes #556

Closed
jumde opened this issue Jul 16, 2018 · 5 comments
Closed

[MacOS] Restricted flag should be set to yes #556

jumde opened this issue Jul 16, 2018 · 5 comments

Comments

@jumde
Copy link
Contributor

jumde commented Jul 16, 2018

screen shot 2018-07-13 at 4 49 44 pm

@bbondy bbondy added this to the Backlog milestone Jul 16, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds 0.55.x Aug 10, 2018
@jumde
Copy link
Contributor Author

jumde commented Aug 16, 2018

Verified this is fixed on Brave | 0.53.3 Chromium: 69.0.3497.12 (Official Build) dev (64-bit)

screen shot 2018-08-16 at 12 30 50 pm

@kjozwiak
Copy link
Member

kjozwiak commented Sep 26, 2018

Went through the following cases and noticed that Tor windows are not being displayed as "restricted", example:

screen shot 2018-09-26 at 5 21 31 pm

@jumde is this expected or any issue?

Went through the following test cases:

  • open several normal windows with a few tabs loaded in each window
  • opened an incognito window with a tabs
  • opened a guest window with a few tabs
  • opened a tor window a few tabs

Used the following build:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@jumde
Copy link
Contributor Author

jumde commented Sep 26, 2018

I would tag this as an enhancement, the tor source code does not have a sandbox profile. I think we should create a new issue for that. cc: @kjozwiak

@LaurenWags
Copy link
Member

Using the same test cases as @kjozwiak I see the same in my Activity Monitor.

screen shot 2018-09-26 at 5 32 31 pm

Used the following cases & build:

  • open several normal windows with a few tabs loaded in each window
  • opened an incognito window with a tabs
  • opened a guest window with a few tabs
  • opened a tor window a few tabs

Went through verification using the following build under macOS 10.12.6 x64 - pass

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@kjozwiak
Copy link
Member

I would tag this as an enhancement, the tor source code does not have a sandbox profile. I think we should create a new issue for that. cc: @kjozwiak

Perfect, thanks @jumde 👍Marking this as passed as everything else is working as expected. Issue #1307 will cover the Tor case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants