Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://welcome Next/Done button doesn't have Brave style - follow up to 6398 #6783

Closed
LaurenWags opened this issue Nov 6, 2019 · 1 comment
Labels
closed/duplicate Issue has already been reported

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #6398

The Next button on the brave://welcome page does not use the Brave style from above issue.

Steps to Reproduce

  1. Launch brave://welcome page. Click on Let's go.
  2. View Next button
  3. Hover over Next button
  4. Click on Next button
  5. When you get to the end of the flow, note the same happens for Done button.

Actual result:

button doesn't have Brave styling

Dark/Light display of button (no interaction):
Next-1
Next-2

Dark/Light hover over button:
Next-Hover
Next-Hover2

Dark/Light click on button:
Next-clicked
Next-Clicked-2

Expected result:

Brave styling as in #6398

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.71.112 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team about-pages/welcome QA/Yes QA/Test-Plan-Specified labels Nov 6, 2019
@LaurenWags
Copy link
Member Author

Duplicate of sub item in #6707

@LaurenWags LaurenWags added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes about-pages/welcome design A design change, especially one which needs input from the design team labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

1 participant