Follow up to #5158 - Bookmark from Other Bookmarks moved to Bookmark bar after sync

[btlechowski]

Follow up to #5158. On initial sync Other Bookmarks folder is moved to Bookmark Bar which is expected. After sync, when a bookmark is added to Other Bookmarks on old brave (1.0.1), it is the moved to Bookmark Bar rather than to Bookmark Bar\Other Bookmarks

Steps to Reproduce

1. Create a sync between old Brave (1.0.x) and new Brave (1.2.x)
2. Wait for the sync
3. Add a bookmark to Other Bookmarks on old Brave
4. Wait for sync

Actual result:

The bookmark is moved to Bookmark Bar on New Brave

The bookmark remains in Other Bookmarks on Old Brave

Expected result:

The bookmark is moved to Bookmark Bar\Other Bookmarks as it happens on initial sync
New Brave

Old Brave

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Old Brave

Brave	1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Windows 7 Service Pack 1 (Build 7601.24530)

New Brave

Brave	1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @darkdh @rebron @AlexeyBarabash @jsecretan

[darkdh]

That is expected, we only migrate what exist in current local “Other bookmarks”, it will be migrated when old Brave upgrade to new version.
Create a “Other bookmarks” folder for those bookmarks before upgrade will introduce inconsistency between mapping which will result old Brave have a permanent “Other bookmarks” and “Other bookmarks” folder coexist.

[bsclifton]

@darkdh if this is expected, can we close this?

[bsclifton]

Closing!