Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Bypass/Disable Accelerated mobile pages(AMP) from Google search. #7366

Closed
thanuj10 opened this issue Oct 30, 2018 · 31 comments
Closed
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". suggestion

Comments

@thanuj10
Copy link

Did you search for similar issues before submitting this one?
Yes

Description:
Disable Google's AMP webpages as it also another form of tracking.

Device Details:

  • Install Type(ARM, x86): All
  • Device(Phone, Tablet, Phablet): All
  • Android Version: Every supported version of brave.

Brave Version:
1.0.60

Steps to reproduce:
1.Search on Google
2.The search results offer AMP pages instead of the regular webpages.

Actual Behavior
Google search serves AMP pages

Expected Behavior
AMP pages should be skipped and users must directly be taken to the actual webpage.

Is this an issue with Beta build?
Yes.

Is this an issue in the currently released version?
Yes.

Can this issue be consistently reproduced?
Yes.

Website problems only:

  • did you check with Brave Shields down?
    -Yes
  • did you check in Chrome for same behavior?
    -Yes

Any related issues:
Issue was opened about a year ago and there has been no improvement in this area.

@thanuj10
Copy link
Author

No news?

@srirambv
Copy link
Contributor

Its on the list but not a priority right now. If you have a fix for this please open a PR and one of the devs would be happy to help you review it and implement it.

@thanuj10
Copy link
Author

thanuj10 commented Dec 20, 2018

Hello. I found a patch to disable AMP links from Brave. Courtesy of Kiwi Browser.
Here is the link - https://github.com/kiwibrowser/privacy_patches/blob/master/Add-possibility-to-remove-AMP-from-search.patch

@srirambv

@Brave-Matt
Copy link

+1 from Zendesk user:
image

@Brave-Matt
Copy link

@anthonypkeane @srirambv,
This issue has been floating around ever since I can remember -- is there any way we can get a second look/a bit of movement on this? More than enough requests for the feature and it's a privacy concern in addition.

@anthonypkeane
Copy link

@jumde @tomlowenthal can you please give your thoughts on this one?

@tildelowengrimm
Copy link
Contributor

I think it makes sense to add as a preference for the people particularly frustrated by AMP. I'm leery of making it a default, because it's a substantial deviation from sites' expected behavior, may make some sites quite a hassle to use, and will probably result in increased data charges for those who flip the switch.

@seanlindo
Copy link

@tomlowenthal

The expected behavior should be I go to the website I think I’m going to..

@tildelowengrimm
Copy link
Contributor

@seanlindo I understand what you're saying: you don't ever want to hit AMP pages, you want to go directly to pages hosted by the publisher. But that's not where the link in the search results page points. Fundamentally, your complaint is with Google (for linking to the AMP page) and the publisher (for posting an AMP page for Google).

Changing the search results page to point somewhere else is a big change. I think your comment implies that the results page offers both a publisher direct link and an AMP link and Brave is deciding to use the AMP link. That's not the case. Google links to an AMP page, and Brave follows that link just like any other. I think it's reasonable to call that the "expected behavior" — tapping a link takes you to the page the link points to. This issue is about creating a feature which makes some links go to a different place.

@andmade
Copy link

andmade commented Sep 5, 2019

Having it as a preference sounds fine to me! I'd just love to see it implemented. This feature is literally the only reason I am using Kiwi Browser, especially since I already use Brave on the desktop.

@szaimen
Copy link

szaimen commented Sep 5, 2019

Please add this AMP-blocking-feature also do Google news:
news.google.com

@morfikov
Copy link

This AMP feature is really irritating...

@anthonypkeane anthonypkeane transferred this issue from another repository Dec 12, 2019
@srirambv srirambv added OS/Android Fixes related to Android browser functionality suggestion labels Dec 12, 2019
@bsclifton bsclifton changed the title Bypass/Disable Accelerated mobile pages(AMP) from Google serach. Bypass/Disable Accelerated mobile pages(AMP) from Google search. Dec 13, 2019
@anthonypkeane anthonypkeane added the priority/P4 Planned work. We expect to get to it "soon". label Sep 2, 2020
@srirambv srirambv changed the title Bypass/Disable Accelerated mobile pages(AMP) from Google search. [Android] Bypass/Disable Accelerated mobile pages(AMP) from Google search. Sep 9, 2020
@Hazbelll
Copy link

Hazbelll commented Oct 26, 2020

Hello from 2020! I'd like to chime in and say I too would love to see this addition. AMP is a plague on mobile.

I hope this has not been forgotten (It's been 2 years since this issue was created).

@t0m5k1
Copy link

t0m5k1 commented Nov 11, 2020

I too would like to see this added to brave on android.

@lazymonkey2
Copy link

I hate how news.google.com is using amp pages.
please add this option to android.

@drjackal-git
Copy link

Hello. I found a patch to disable AMP links from Brave. Courtesy of Kiwi Browser.
Here is the link - https://github.com/kiwibrowser/privacy_patches/blob/master/Add-possibility-to-remove-AMP-from-search.patch

@srirambv

Why can't dev just merge this patch into brave?

@FairlyIncognito
Copy link

Time for Brave to get this done. Other mobile browsers, like Kiwi, already has this feature.

We're nearing 2021 and this still haven't been implemented.

@Hazbelll
Copy link

Hazbelll commented Jan 21, 2021

Hello from 2021! At this pace, it will soon be 3 years since this issue was created.

Incredibly sad such a requested feature has been left neglected, even rude that after being bumped, @srirambv lowers its priority, but provides no explanation as to why.

Isn't it a little contradictory a "privacy respecting browser" does not offer a way to bypass Google's AMP foolery?

@bsclifton
Copy link
Member

@Hazbelll and others - apologies no progress was made here. We did have someone looking at it a while back (Mar 2020) but they've since left and the work has become a bit stale:
brave/brave-core#4950

Just like all the issues in the issue log, this has a relative priority associated with it. While I'd love this feature too, P4 is at the bottom of things that we'll grab. There are coming up on 3,000 issues and a limited amount of developers here working on those issues (including keeping Chromium up to date).

cc: @anthonypkeane in case we wanted to reprioritize this specific issue

@mjlabe
Copy link

mjlabe commented Mar 27, 2021

I tested the feature on Kiwi and, as I expected, it didn't work. I created my own Google News site where I scraped the main page and replaced the amp urls. What I learned is every couple of months, Google slightly changes the formatting to prevent scraping. As result, any patch that I could conceivably think of would break frequently and I gave up. If anyone has a long term idea, please share. Maybe I'll look into an ML solution. 😛

Setting this to a low priority was generous imo. I don't think there is a permanent solution, so it unfortunately should probably be closed.

@ChildishGiant
Copy link

ChildishGiant commented Jun 12, 2021

This bot is open source and removes AMP links, maybe someone could have a look at it? https://github.com/KilledMufasa/AmputatorBot

@NuLL3rr0r
Copy link

A privacy-focused browser liked Brave should really implement this.

@ChildishGiant
Copy link

This could easily be done using greaselion at the point. https://www.amputatorbot.com/

@t0m5k1
Copy link

t0m5k1 commented Sep 14, 2021 via email

@SwiftyPop
Copy link

Any update on this? It's been a while

@anthonypkeane
Copy link

Linked to #18321

Our team are working in this. Thanks

@Ellibis
Copy link

Ellibis commented Apr 12, 2022

Would love to have this feature... <3

@anthonypkeane
Copy link

#21643

@bsclifton
Copy link
Member

@ShivanKaul can we close this out?

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Jun 24, 2022

Yes! #20458 and brave/brave-core#13001 addressed this, in a more privacy-preserving way than tampermonkey or injecting a script :)

@ShivanKaul ShivanKaul added the closed/duplicate Issue has already been reported label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". suggestion
Projects
None yet
Development

No branches or pull requests