Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Beta icon for ad notification to distinguish between release and beta ads #7571

Closed
srirambv opened this issue Jan 2, 2020 · 3 comments · Fixed by brave/brave-core#8647
Closed

Use Beta icon for ad notification to distinguish between release and beta ads #7571

srirambv opened this issue Jan 2, 2020 · 3 comments · Fixed by brave/brave-core#8647
Labels
design A design change, especially one which needs input from the design team feature/ads OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.25.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Jan 2, 2020 •
edited
Loading

Description

Use Beta icon for ad notification to distinguish between release and beta ads

Steps to Reproduce

  1. Install Android-core and release
  2. Enable rewards on both
  3. Wait for ad notification to show up from beta

Actual result:

image

Expected result:

Should have beta icon to distinguish ad notifications

Reproduces how often:

Easy

Brave version (brave://version info)

Android-core beta

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @anthonypkeane @jamesmudgett @SergeyZhukovsky
@srirambv srirambv added design A design change, especially one which needs input from the design team feature/rewards QA/Yes feature/ads android-core-release OS/Android Fixes related to Android browser functionality labels Jan 2, 2020
@srirambv srirambv added this to the Android-Beta milestone Jan 7, 2020
@srirambv srirambv added priority/P2 A bad problem. We might uplift this to the next planned release. and removed android-core-release labels Jan 8, 2020
@srirambv srirambv removed this from the Android-Beta milestone Jan 8, 2020
@LaurenWags LaurenWags mentioned this issue Feb 18, 2020
Closed
@bsclifton
Copy link
Member

Notifications are being reworked right now - marking as blocked while folks work through brave/brave-core#6451

@samartnik samartnik mentioned this issue Apr 26, 2021
Merged
24 tasks
@samartnik samartnik added this to the 1.25.x - Nightly milestone Apr 27, 2021
@srirambv
Copy link
Contributor Author

srirambv commented May 6, 2021

Verification passed on OnePlus 6T with Android 10 running 1.25.51 x64 beta build

  • Verified ad notifications use Beta icon
    image

Verification passed on Samsung Tab A with Android 10 running 1.25.51 x64 beta build

  • Verified ad notifications use Beta icon
    image

@stephendonner
Copy link

Removing blocked label, as brave/brave-core#6451 is now closed.

This was referenced May 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team feature/ads OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Fixed icon and string brave/brave-core
5 participants
@stephendonner @bsclifton @NejcZdovc @srirambv @samartnik