Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after tipping, the banner does not have good keyboard accessibility #7611

Closed
LaurenWags opened this issue Jan 6, 2020 · 2 comments
Closed

Comments

@LaurenWags
Copy link
Member

Description

After you tip, the "thank you" message is in-line on the tip banner in 1.2.x and above. However, after tipping there is no element highlighted (showing a box around it) to indicate that it is active on the tip banner. This is necessary for accessibility so users can know where they are on the banner. If you tab a bit eventually something will get highlighted, but then you encounter #6986 and leave the tip banner, unable to return via tab.

Steps to Reproduce

  1. Have rewards enabled and BAT in your wallet.
  2. Go to a verified publisher.
  3. Open tip banner.
  4. Tip site (note, thank you is "in line" in 1.2.x and above)
  5. Thank you message is displayed where the tip amounts were.

Actual result:

Nothing on the tip banner is highlighted w/ a box to indicate where you are - same occurs for both monthly and one time tips:
Screen Shot 2020-01-06 at 10 05 04 AM

Expected result:

Something should be highlighted and user selectable via keyboard - perhaps the Share option? This is for product to determine.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.1.x it is n/a, but yes for 1.2.x
  • Can you reproduce this issue with the beta channel? probably
  • Can you reproduce this issue with the dev channel? probably
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mandar-brave @alexwykoff

@emerick
Copy link
Contributor

emerick commented Jul 7, 2022

Unable to repro. I think the most recent redesign of the tipping banner ended up addressing this, but please reopen if I'm incorrect.

@emerick emerick closed this as completed Jul 7, 2022
@emerick emerick added this to the 1.43.x - Nightly milestone Jul 7, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 8, 2022
@LaurenWags
Copy link
Member Author

Verified with

Brave | 1.43.61 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | macOS Version 12.5 (Build 21G72)

Could not reproduce with STR from description.

@LaurenWags LaurenWags added release-notes/exclude QA Pass-macOS and removed release-notes/include QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants