Switching between built-in Dark and Light theme should change DevTools theme setting

[petemill]

Description

When changing between dark and light themes is possible via #789, when that setting is changed then the setting for DevTools theme should also change.

Test plan

1. Start browser with clean profile
2. Open devtools (context menu -> Inspect)
3. Check devtools theme uses current brave theme
4. Close devtools
5. Change to different brave theme type
6. Check devtools theme uses current brave theme
7. Change devtools theme type
8. Close/Reopen devtools
9. Check changed devtools theme type is persisted

[jakerockland]

@petemill bit curious, I saw that the functionality of dark mode is merged in brave-core but can't seem to find the ability in my latest updated version of Brave, is enabling dark more still something that isn't public yet or am I just looking in the wrong place?

[srirambv]

@jakerockland you can manually change the dev tools theme.

Currently both are independent in changing color mode. This issue is to tie the changes which is still not implemented.

[jakerockland]

Ah @srirambv I'm a bit confused, this seems to change the theme for the dev tools but not for the browser itself, is there a way currently to set the theme for the browser?

[srirambv]

You can change UI theme under Appearance in chrome://setttings

[jakerockland]

hrm I think I'm confused somewhere in the process—am I running a different version of Brave?

 
Brave: 0.24.0 
V8: 6.9.427.23 
rev: f657f15bf7e0e0c50a2b854c6b05edb59bfc556c 
Muon: 8.1.6 
OS Release: 18.0.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 69.0.3497.100

[srirambv]

oh yes you are still on the muon version. This is only available on the new brave-core builds. You can download the test build from here

[jakerockland]

Mmm this makes much more sense now haha, thanks so much @srirambv 👍

[bbondy]

Adding missing 0.59.x milestone.

[GeetaSarvadnya]

Verification passed on

Brave	0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision	08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS	Windows

• Verified the test plan from description.

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

• Verified the test plan from description.

Verified passed with

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X

• Verified STR from description