Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd-party cookie shield prevents slideshare.net navigation #7868

Closed
ryanbr opened this issue Jan 22, 2020 · 5 comments
Closed

3rd-party cookie shield prevents slideshare.net navigation #7868

ryanbr opened this issue Jan 22, 2020 · 5 comments
Labels
closed/works-for-me feature/cookie-allow-list priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-all-cookies workaround/shields-down

Comments

@ryanbr
Copy link

ryanbr commented Jan 22, 2020

Description

Visit: https://support.blogactiv.eu/2015/04/24/how-to-embed-slideshare/ Embedded Slideshare doesn't navigate.

Steps to Reproduce

  1. https://support.blogactiv.eu/2015/04/24/how-to-embed-slideshare/
  2. Click arrow buttons, nothing happens

Actual result:

Non-functional slideshare.net element

Expected result:

Allow Slideshare.net navigation element to work

Reproduces how often:

Easily.

Brave version (brave://version info)

Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Blocking 3rd-party cookies for slideshare.net will prevent naviagtion, Allow All Cookies will fix this.

@ryanbr ryanbr added webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/shields-down webcompat/shields Shields is breaking a website. workaround/allow-all-cookies feature/cookie-allow-list labels Jan 22, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 6, 2020
@ryanbr
Copy link
Author

ryanbr commented May 1, 2020

2 domains being used;

"https://*.slideshare.net/*"
"https://*.slidesharecdn.com/*"

@ryanbr
Copy link
Author

ryanbr commented May 1, 2020

Shot in the dark from https://github.com/brave/brave-core/compare/fix-google-drive-autoplay-bj But I could be wrong. But something like this?

constexpr char kSlideshare[] = "https://[*.]slideshare.net/*";
constexpr char kSlidesharecdn[] = "https://[*.]slidesharecdn.com/*";
[...]
{ ContentSettingsPattern::FromString(kSlideshare), ContentSettingsPattern::FromString(kSlidesharecdn)}, { ContentSettingsPattern::FromString(kSlidesharecdn), ContentSettingsPattern::FromString(kSlideshare) },

@pes10k
Copy link
Contributor

pes10k commented May 1, 2020

I see this in the logs

Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at https://public.slidesharecdn.com/ss_foundation/combined_player_presentation.js?1801753e9b:1:15785

I think the better solution here is #8514, which would be a good, systematic level fix

@pes10k
Copy link
Contributor

pes10k commented May 1, 2020

That being said, once brave/brave-core#5433 lands, i'd be a-ok adding these exceptions in, but would like to mark them for removal once #8514 lands

@ryanbr
Copy link
Author

ryanbr commented Dec 9, 2020

This is now working, closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me feature/cookie-allow-list priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-all-cookies workaround/shields-down
Projects
None yet
Development

No branches or pull requests

3 participants