Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Toolbar Spacing #791

Closed
petemill opened this issue Aug 20, 2018 · 1 comment · Fixed by brave/brave-core#454
Closed

Extra Toolbar Spacing #791

petemill opened this issue Aug 20, 2018 · 1 comment · Fixed by brave/brave-core#454
Assignees
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@petemill
Copy link
Member

petemill commented Aug 20, 2018

At the moment there are fixed width items on the toolbar, and expanding items.

Fixed items:

  • Toolbar Navigation icons
  • Menu button

Expanding items:

  • BrowserActions (extensions)
  • LocationBar

The expanding items take up the remaining space after the fixed items are given space. There is an algorithm that determines the ratio of space allocated to LocationBar and BrowserActions.

A further complication is that the BrowserActions area is semi-fixed in that it has a dynamic max-width depending on how many extensions are installed.

With Brave, the intention is to add a third expanding item:

  • Space

We need to decide exactly how this Space item is to take width away from both the LocationBar and the BrowserActions given the varying maximum's of each.

image

@srirambv
Copy link
Contributor

srirambv commented Oct 17, 2018

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified with both extensions and no extensions

Verified passed with

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X
  • Verified with both extensions and no extensions

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (32-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants