Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad notification shows up even when Brave-Beta is not running #7917

Closed
srirambv opened this issue Jan 25, 2020 · 4 comments · Fixed by brave/brave-core#4805
Closed

Ad notification shows up even when Brave-Beta is not running #7917

srirambv opened this issue Jan 25, 2020 · 4 comments · Fixed by brave/brave-core#4805
Assignees
@gdregalo
Labels
android-core-release ARM Android ARM related issues bug feature/ads OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
Android 1.7.x Rel...

Comments

@srirambv
Copy link
Contributor

Description

Ad notification shows up even when Brave-Beta is not running

Steps to reproduce

  1. Run brave and remove from memory
  2. Ads show up even when app is removed from memory

Actual result

Ad notification showed up on device even when Brave-Beta wasn't running in background

Expected result

Should not show ad notification if app isn't running

Issue reproduces how often

Issue happened on release build logged https://github.com/brave/browser-android-tabs/issues/2478. After upgrading to Beta reproduced on android-core as well

Issue happens on

  • Current Play Store version? Yes
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Pixel 3XL
  • Android version: 10

Brave version

1.5.59

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added bug feature/rewards QA/Yes feature/ads OS/Android Fixes related to Android browser functionality ARM Android ARM related issues android-core-release labels Jan 25, 2020
@srirambv
Copy link
Contributor Author

Adding feature/rewards label as its related to ads and issue added to Android-Core project board

@LaurenWags
Copy link
Member

++ from me

@gdregalo gdregalo mentioned this issue Mar 2, 2020
Merged
29 tasks
@gdregalo gdregalo added this to the 1.7.x - Nightly milestone Mar 5, 2020
@bsclifton bsclifton mentioned this issue Mar 16, 2020
Closed
This was referenced Apr 2, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Apr 3, 2020

Moving to Android 1.7.x milestone as this Android specific issue

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.7.102 x64 stable build

  • Verified no ads show up when the app is removed from memory

Verification passed on Samsung Tab A with Android 9 running 1.7.102 x64 stable build

  • Verified no ads show up when the app is removed from memory

@srirambv srirambv mentioned this issue Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdregalo gdregalo

Labels
android-core-release ARM Android ARM related issues bug feature/ads OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
Android 1.7.x Release
Development

Successfully merging a pull request may close this issue.

[Android] Ad notification shows up even when Brave-Beta is not running #7917 brave/brave-core
5 participants
@kjozwiak @NejcZdovc @srirambv @LaurenWags @gdregalo