Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallet Dark theme [Follow up to #6381] #8018

Closed
srirambv opened this issue Feb 3, 2020 · 3 comments · Fixed by brave/ethereum-remote-client#116
Closed

Crypto Wallet Dark theme [Follow up to #6381] #8018

srirambv opened this issue Feb 3, 2020 · 3 comments · Fixed by brave/ethereum-remote-client#116

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2020

Description

Follow up issue for dark theme on Crypto Wallet page. Original issue #6381

Actual result:

  • Brave Rewards on disclaimer message is not distinguishable that it's a hyperlink
    image
  • Connect Hardware doens't differentiate between which one is selected
    image
  • Create Account doesn't show cancel button in disabled state
    image
  • Dropdown on import doesn't show entries correctly
    image
  • Wyre and CoinSwitch logo needs to have more contrast on deposit popup
    image
  • Add recipient with incorrect address
    image
  • Default Gas value selection isn't properly highlighted
    image
  • Advanced Gas selection text is not visible
    image
  • Connect request popup verification icon has white border. Dotted line between address is not visible
    image
  • Add token on home screen doesn't visually convery its a clickable link
    image
  • Add token popup Learn more needs more contrast
    image
  • Add token auto fill selection
    image
  • Address scan modal
    image
  • Send transaction Eth icon is not visible
    image
  • Customize gas fee during transaction
    image
  • Pending transaction text is not visible for ongoing transaction
    image
  • Fiat currency dropdown in settings
    image
  • Reset account needs to have warn colour on dark mode as well
    image
  • Revel seed words needs to have warn colour
    image
  • Import using seed phrase on welcome page needs to have a contrasting text colour
    image

Expected result:

Proper contrast on text and icons and button for dark mode

Reproduces how often:

Easy

Brave version (brave://version info)

Component 0.1.37

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett

@srirambv
Copy link
Contributor Author

srirambv commented Feb 6, 2020

Verification passed on

  • Verified above listed scenarios are fixed for dark theme
  • Welcome disclaimer
    image
  • Connect hardware
    image
  • Import dropdown
    image
  • Deposit modal with Wyre and CoinSwitch logo
    image
  • Invalid recepient address
    image
  • Default Gas value selection
    image
  • Advance gas price details
    image
  • No white border on check mark
    image
  • Add Token clearly distinguishable as link
    image
  • QR Scan modal
    image
  • Send Transaction
    image
  • Pending transactoins message
    image
  • FIat curency list
    image
  • Reset sites warn button
    image
  • Reveal seed words warn button
    image
  • Reset account warn button
    image
  • Import and restore links with proper highlighting
    image

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42
  • CW discalimer
    image
  • Connect hardware
    image
  • Import dropdown
    image
  • Deposit popup logos
    image
  • Incorrect recipient address
    image
  • Default gas value selectoin
    image
  • Advance gas option
    image
  • Connect wallet popup
    image
  • Add token on wallet home screen
    image
  • Add token popup
    image
  • Token popup autofill
    image
  • Scan QR code
    image
  • Eth icon on send transaction
    image
  • Customize gas basic
    image
  • Pending transaction
    image
  • Fiat currency drop down
    image
  • Advanced settings buttons
    image
  • Security and privacy settings button
    image
  • Welcome page links
    image

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants