Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Rate Brave #8243

Closed
anthonypkeane opened this issue Apr 18, 2019 · 7 comments · Fixed by brave/brave-core#5501
Closed

[Android] Rate Brave #8243

anthonypkeane opened this issue Apr 18, 2019 · 7 comments · Fixed by brave/brave-core#5501
Assignees
@jamesmudgett @deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@anthonypkeane
Copy link

Description

Add the ability for users to easily rate Brave

Some like https://github.com/hotchemi/Android-Rate

@jamesmudgett to help design a nice flow
@anthonypkeane
Copy link
Author

Potentially follow login from brave/brave-ios#732

@EyanGoldman
Copy link

This library should be of help: https://github.com/codemybrainsout/smart-app-rate

@EyanGoldman
Copy link

Spec: https://docs.google.com/document/d/1MHMXzlF7vvXQlISet0Pq4DYfxxMbOWSNjxrTQhW3trM/edit?usp=sharing

@anthonypkeane
Copy link
Author

Needs endpoint to collect feedback which is TBD.

@anthonypkeane
Copy link
Author

@jamesmudgett can you pls finalize the design for this?

@anthonypkeane
Copy link
Author

anthonypkeane commented Oct 2, 2019 •
edited
Loading

YT have a nice design for this screen

Screenshot 2019-09-17 at 17 53 47

and some simple wireframe: https://docs.google.com/presentation/d/1yS5NLVgLTh6eW-QyP-PyG0zsAL9nsyv-ZxC_ZEoaiys/edit#slide=id.p

@anthonypkeane anthonypkeane transferred this issue from another repository Feb 13, 2020
@anthonypkeane anthonypkeane added this to the Android 1.6.x Release milestone Feb 13, 2020
@SergeyZhukovsky SergeyZhukovsky removed this from the Android 1.8.x Release milestone May 6, 2020
@deeppandya deeppandya mentioned this issue May 10, 2020
Merged
32 tasks
@deeppandya deeppandya added this to the 1.11.x - Nightly milestone May 29, 2020
@deeppandya deeppandya added OS/Android Fixes related to Android browser functionality QA/Yes labels Jun 8, 2020
@LaurenWags LaurenWags changed the title Rate Brave [Android] Rate Brave Jun 16, 2020
@srirambv srirambv mentioned this issue Jul 7, 2020
Closed
10 tasks
This was referenced Jul 8, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Jul 27, 2020 •
edited by LaurenWags
Loading

Verification passed on OnePlus 6T with Android 10 running 1.11.98 x64 build

Verified "Rate Brave" settings is shown under "Display" in menu
Verified clicking on "Rate Brave" from menu opens up the modal for feedbackVerified "Rate Brave" settings is shown under "Display" in menu
Verified clicking sad face or neutral face on rate brave modal opens up the feedback input dialog
Verified clicking on the happy face shows thankyou message and provides option to Rate on Google Play Store
Restart and time duration
  • Verified clicking on Rate switches to PlayStore and opens up Brave listing
  • Verified rate brave modal shows up based on specified number of restarts when the time frame is met
  • Verified clicking on rate brave manually from settings doesn't affect the specified number of restarts and time duration
  • Verified feedback sent via app is captured in backend
Translated Rate Brave models
Japanese
French
German

Verification passed on Samsung Tab A with Android 10 running 1.11.100 x64 build

Verified "Rate Brave" settings is shown under "Display" in menu
Verified clicking on "Rate Brave" from menu opens up the modal for feedbackVerified "Rate Brave" settings is shown under "Display" in menu
Verified clicking sad face or neutral face on rate brave modal opens up the feedback input dialog
Verified clicking on the happy face shows thankyou message and provides option to Rate on Google Play Store
Restart and time duration
  • Verified clicking on Rate switches to PlayStore and opens up Brave listing
  • Verified rate brave modal shows up based on specified number of restarts when the time frame is met
  • Verified clicking on rate brave manually from settings doesn't affect the specified number of restarts and time duration
  • Verified feedback sent via app is captured in backend
Translated Rate Brave models
Japanese
French
German

Verification passed on Asus Zenfone (x86) with Android 6 running 1.11.105 BraveModernx86.apk

Verified "Rate Brave" settings is shown under "Display" in menu

Android-English-settings

Verified clicking on "Rate Brave" from menu opens up the modal for feedback

Android-English-rate

Verified clicking sad face or neutral face on rate brave modal opens up the feedback input dialog

Android-English-feedback

Verified clicking on the happy face shows thankyou message and provides option to Rate on Google Play Store

Android-English-happyplaystore

Restart and time duration
  • Verified clicking on Rate switches to PlayStore and opens up Brave listing
  • Verified rate brave modal shows up based on specified number of restarts when the time frame is met
  • Verified clicking on rate brave manually from settings doesn't affect the specified number of restarts and time duration
  • Verified feedback sent via app is captured in backend
Translated Rate Brave models
Japanese

Android-Japanese-1

Android-Japanese-2

Android-Japanese-3
French

Android-French-1

Android-French-2

Android-French-3
German

Android-German-1

Android-German-2

Android-German-3

@LaurenWags LaurenWags mentioned this issue Jul 27, 2020
Closed
@srirambv srirambv mentioned this issue Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmudgett jamesmudgett

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Rate brave dp brave/brave-core
7 participants
@jamesmudgett @deeppandya @anthonypkeane @EyanGoldman @SergeyZhukovsky @srirambv @LaurenWags