Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallet dark theme final follow up #8425

Closed
srirambv opened this issue Feb 27, 2020 · 2 comments
Closed

Crypto Wallet dark theme final follow up #8425

srirambv opened this issue Feb 27, 2020 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

Crypto Wallet dark theme final follow up

Actual result:

H/w Address selection
image

Token Auto fill selection
image

Account connection linkage
image

Expected result:

One fix for three issues and hopefully upstream support for theming

Reproduces how often:

Easy

Brave version (brave://version info)

Component : 0.1.47

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv srirambv added priority/P4 Planned work. We expect to get to it "soon". QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support feature/themes labels Feb 27, 2020
@srirambv
Copy link
Contributor Author

Sign contract window doesn't show text in dark theme. Found while testing #8223
image

@srirambv
Copy link
Contributor Author

Closing this in favour of #11267.

Signed contract window is fixed on MM v8 rebase
image

Connect wallet shows accounts linkage correctly on MM v8 rebase
image

Connect hardware and drop down suggestion are still an issue

@srirambv srirambv removed this from the Ethereum Remote Client 1.0.23 milestone Aug 17, 2020
@srirambv srirambv added closed/not-actionable and removed QA/Yes feature/themes priority/P4 Planned work. We expect to get to it "soon". labels Aug 17, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants