Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Reset rewards doesn't work #8776

Closed
srirambv opened this issue Mar 20, 2020 · 3 comments · Fixed by brave/brave-core#14607
Closed

[Android] Reset rewards doesn't work #8776

srirambv opened this issue Mar 20, 2020 · 3 comments · Fixed by brave/brave-core#14607
Assignees
@deeppandya
Labels
ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Reset rewards doesn't reset correctly if rewards page is opened

Steps to reproduce

  1. Install 1.5.9 and enable rewards
  2. Open rewards page in a new tab
  3. Use browser normally with other rewards page opened in a tab
  4. Upgrade to 1.5.113
  5. Reset rewards from advance settings doesn't prompt for relaunch
  6. Go back to rewards page its turned off instead of reset
  7. Try rewards reset again, prompts for restart and finally is reset

Actual result

https://bravesoftware.slack.com/archives/CM17J5QMU/p1584684109200800

Expected result

Rewards should be reset even if rewards page is opened

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? no
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.5.113

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@srirambv srirambv added bug feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality ARM Android ARM related issues labels Mar 20, 2020
@srirambv srirambv mentioned this issue Mar 20, 2020
Closed
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 2, 2020
This was referenced Apr 19, 2021
Closed
Closed
@srirambv srirambv changed the title [Android] Reset rewards doesn't reset correctly if rewards page is opened [Android] Reset rewards doesn't work Apr 19, 2021
@srirambv
Copy link
Contributor Author

+1 from @Maxime-J via #14055 and @newuser-web via #15351

@stephendonner stephendonner mentioned this issue Dec 30, 2021
Closed
50 tasks
@srirambv srirambv mentioned this issue Jan 31, 2022
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 11, 2022
Closed
@Uni-verse Uni-verse mentioned this issue Mar 2, 2022
Closed
51 tasks
@LaurenWags
Copy link
Member

Still reproduces with 1.38.109.

@Miyayes should this be prioritized for Android work?

@bsclifton bsclifton mentioned this issue Jun 13, 2022
Open
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 13, 2022
@deeppandya deeppandya mentioned this issue Aug 12, 2022
Merged
25 tasks
@deeppandya deeppandya added this to the 1.44.x - Nightly milestone Aug 12, 2022
@Miyayes Miyayes mentioned this issue Sep 13, 2022
Closed
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 21, 2022
@stephendonner
Copy link

stephendonner commented Sep 21, 2022 •
edited
Loading

Verified PASSED(*) using 1.44.95, Chromium 106.0.5249.40 on a Google Pixel XL running Android 9.

Steps:

  1. install 1.44.95
  2. launch Brave
  3. tap on the 3-dots menu
  4. tap on Settings
  5. tap on About Brave
  6. tap 10x on Application version
  7. tap on Developer options
  8. tap on QA Preferences
  9. enter the code
  10. tap to set Use Rewards staging server to Enabled
  11. tap Later
  12. tap to set Verbose Logs for Ad-Rewards
  13. tap Relaunch now
  14. tap on the BAT icon
  15. tap Start using Brave Rewards
  16. tap on Unverified
  17. tap Continue
  18. tap Uphold
  19. tap on Authorize
  20. log in to staging/sandbox
  21. tap Next
  22. wait
  23. you'll see 0.300 BAT added to Estimated Earnings
  24. tap on the 3-dots menu
  25. tap Settings
  26. tap Brave Rewards
  27. tap Reset Brave Rewards
  28. tap Confirm
  29. tap Relaunch Now
  30. look at your brave://rewards tab

Confirmed that everything except for Estimated Earnings was cleared and reset (with Brave Private Ads and Auto-Contribute both now set to Disabled)

example example example example example step 30
Screenshot_20220922-000559 Screenshot_20220922-000611 Screenshot_20220922-000620 Screenshot_20220922-000628 Screenshot_20220922-000638 Screenshot_20220922-000650

(*) NOTE: spun off #25541 for Estimated Earnings. It's correct when tapping on the BAT icon overlay, as shown below:

Screenshot_20220921-155727

@stephendonner stephendonner added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Resolve reset rewards feature brave/brave-core
7 participants
@stephendonner @kjozwiak @deeppandya @anthonypkeane @Miyayes @srirambv @LaurenWags