Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monthly contributions not reflected in panel summary #8841

Closed
LaurenWags opened this issue Mar 24, 2020 · 2 comments · Fixed by brave/brave-core#5060
Closed

monthly contributions not reflected in panel summary #8841

LaurenWags opened this issue Mar 24, 2020 · 2 comments · Fixed by brave/brave-core#5060

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #8467

After monthly contributions (recurring tips) have been contributed, they are not reflected on the summary displayed from the rewards panel. They are displayed on the summary on brave://rewards and in the Monthly Contributions table.

Steps to Reproduce

  1. Launch clean profile from staging with short reconcile interval
  2. Enable Rewards, claim UGP
  3. Do a one time tip, see it reflected in panel summary
  4. Set up a recurring tip.
  5. Add sites to AC table, adjust monthly budget if necessary depending on wallet balance.
  6. Wait for reconcile.
  7. Once reconcile is complete, look at panel summary

Actual result:

Monthly Contributions are not listed in panel summary
Screen Shot 2020-03-24 at 1 47 25 PM

Expected result:

Should be listed in panel summary. Here is what should be shown (from brave://rewards page)
Screen Shot 2020-03-24 at 1 46 12 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, does not reproduce in 1.5.115
  • Can you reproduce this issue with the beta channel? unsure, probably
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @mandar-brave @brave/legacy_qa

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

image

@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 31, 2020

Verified passed with

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-03-31 at 10 09 55 AM

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment