Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping files onto New Tab doesn't work #887

Closed
bsclifton opened this issue Aug 30, 2018 · 3 comments
Closed

Dropping files onto New Tab doesn't work #887

bsclifton opened this issue Aug 30, 2018 · 3 comments
Labels
closed/no-milestone drag-and-drop feature/new-tab priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#10497

Steps to reproduce

  1. Open a new tab (verify it shows dashboard with tiles/time/# ads blocked/etc)
  2. Try dragging any file (image, html file, etc) into browser
  3. File does not open in browser
@bsclifton bsclifton added this to the Backlog milestone Aug 30, 2018
@bsclifton bsclifton mentioned this issue Aug 30, 2018
Closed
@bsclifton bsclifton mentioned this issue Sep 7, 2018
Closed
@bsclifton bsclifton modified the milestones: 1.x Backlog, 1.0 Sep 10, 2018
@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog Sep 29, 2018
@rebron
Copy link
Collaborator

rebron commented Feb 6, 2019

Looks like this is fixed in 61.x. I can reproduce this issue in 60.x though.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron closed this as completed Feb 21, 2019
@rebron rebron added this to the Dupe / Invalid / Not actionable milestone Mar 5, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone Mar 13, 2019
@rebron
Copy link
Collaborator

rebron commented Mar 13, 2019

I closed this prematurely. Drag and dropping files works just not with new tab page.

@rebron rebron reopened this Mar 13, 2019
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 27, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 29, 2020

Closing. Verified this works on Windows and macOS. Used both image file and html file on New Tab page.

Brave 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Windows 10 OS Version 1903 (Build 18362.720)

@rebron rebron closed this as completed Apr 29, 2020
@snyk-bot snyk-bot mentioned this issue Jan 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/no-milestone drag-and-drop feature/new-tab priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @bsclifton @rebron