-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmetic filtering causes a layout re-flow during page-load - follow up to #8197 #9051
Comments
Reproduced on Ubuntu
|
cc: @pes10k @antonok-edm can you take a look? |
In general, this isn't a bug, its a necessary part of the "distinguish 1p vs 3p ads" requirement. We hide everything and then unhide things the algorithm thinks is a 1p ad. Unfortunately, that will cause somethings to jump around as the "party-ness" of it changes. However, in this specific case, i dont know why the ad would be classified as 1p… It looks like uBO uses scriptlets to clean up this page. A fix for scriptlets should be incoming shortly (re @antonok-edm). If that doesn't address the problem here, lets re-visit then |
@antonok-edm related issue? #9496 or resolved with brave/brave-core#5402? |
@rebron Still seeing similar jumping around the advertisement slots using the latest Nightly. I don't think the scriptlets actually touch any of those elements. |
Looking good here, tested on latimes.com @LaurenWags Feel free to re-open if its still an issue, |
Description
Found while testing #8197
Issue as originally described in above issue is still occurring. If I navigate to articles on latimes.com (with cosmetic blocking enabled), page content jumps around. If I disable cosmetic blocking, page content does not jump around.
Steps to Reproduce
Actual result:
Content jumps (content jumps when cosmetic blocking is on/default)
Expected result:
Content should not jump (it does not jump when cosmetic blocking is disabled)
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @rebron @brave/legacy_qa
The text was updated successfully, but these errors were encountered: