Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Open tabs in Custom Tabs option #9074

Closed
SergeyZhukovsky opened this issue Apr 7, 2020 · 3 comments · Fixed by brave/brave-core#5199
Closed

[Android] Open tabs in Custom Tabs option #9074

SergeyZhukovsky opened this issue Apr 7, 2020 · 3 comments · Fixed by brave/brave-core#5199
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android x86 QA/Yes regression release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

Description

In old tabs version we had an option Settings->Accessibility->Open tabs in Custom Tabs. It looks like it is missed in the brave-core based build

Steps to reproduce

  1. Go to Settings->Accessibility.

Actual result

There is no Open tabs in Custom Tabs option

Expected result

There is Open tabs in Custom Tabs option
Screenshot_20200407-160845

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@SergeyZhukovsky SergeyZhukovsky added QA/Yes regression OS/Android Fixes related to Android browser functionality labels Apr 7, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the Android 1.7.x Release milestone Apr 7, 2020
@samartnik samartnik self-assigned this Apr 7, 2020
@srirambv srirambv added the feature/global-settings Settings at browser level independent of shields settings label Apr 8, 2020
@samartnik
Copy link
Contributor

As per discussion https://bravesoftware.slack.com/archives/CM17J5QMU/p1586351671279700
option is moved to Controls section
Screenshot from 2020-04-08 15-40-27

@samartnik
Copy link
Contributor

It also requires additional translations

@srirambv
Copy link
Contributor

srirambv commented Apr 24, 2020

Verification passed on OnePlus 6T with Android 10 running 1.7.100 x64 stable build

  • Verified opening a link in custom tab works when the setting is enabled
  • Verified custom tabs are not loaded when the setting is turned off
  • Verified toggle setting doesn't require browser restart
  • Verified Open tabs in Custom Tabs is under Controls section in settings
    image

Verification passed on Asus Zenfone (x86) with Android 6 running 1.7.102 BraveModernx86.apk

  • Verified opening a link in custom tab works when the setting is enabled
  • Verified custom tabs are not loaded when the setting is turned off
  • Verified toggle setting doesn't require browser restart
  • Verified Open tabs in Custom Tabs is under Controls section in settings
    Screenshot_20200429-151230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android x86 QA/Yes regression release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@kjozwiak @SergeyZhukovsky @srirambv @LaurenWags @samartnik and others