Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Bat Ads Service" should only be running if Brave Ads is enabled #9196

Closed
NejcZdovc opened this issue Apr 14, 2020 · 3 comments · Fixed by brave/brave-core#5824
Closed

"Bat Ads Service" should only be running if Brave Ads is enabled #9196

NejcZdovc opened this issue Apr 14, 2020 · 3 comments · Fixed by brave/brave-core#5824
Assignees
@tmancey
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

image

We should only start ads process when ads are enabled
@NejcZdovc NejcZdovc mentioned this issue Apr 14, 2020
Closed
@tmancey tmancey changed the title Start ads process on when ads are enabled Start ads process only when ads are enabled Apr 14, 2020
@tmancey tmancey changed the title Start ads process only when ads are enabled "Bat Ads Service" should only be running if Brave Ads is enabled May 3, 2020
@rebron
Copy link
Collaborator

rebron commented May 29, 2020

@jsecretan should this have higher priority?

@rebron rebron added the QA/Yes label May 29, 2020
@tmancey tmancey self-assigned this Jun 11, 2020
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 11, 2020
@tmancey tmancey mentioned this issue Jun 11, 2020
Merged
32 tasks
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 12, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 31, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Clean profile - Rewards never enabled, confirmed BAT Ads Service is not running:
9196 - clean profile

Rewards enabled, ads enabled, confirmed BAT Ads Service is running:
9196 - Rewards enabled, ads enabled

Rewards enabled, ads disabled, confirmed BAT Ads Service is not running:
9196 - Rewards enabled, ads disabled

Rewards enabled, then disabled, confirmed BAT Ads Service is not running:
9196 - Rewards enabled then disabled

Verification passed on

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Clean profile - Rewards never enabled, confirmed BAT Ads Service is not running:
image

Rewards enabled, ads enabled, confirmed BAT Ads Service is running:
image

Rewards enabled, ads disabled, confirmed BAT Ads Service is not running:
image

Rewards enabled, then disabled, confirmed BAT Ads Service is not running:
image

Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Clean profile - Rewards never enabled, confirmed BAT Ads Service is not running:
image

Rewards enabled, ads enabled, confirmed BAT Ads Service is running:
image

Rewards enabled, ads disabled, confirmed BAT Ads Service is not running:
image

Rewards enabled, then disabled, confirmed BAT Ads Service is not running:
image

Reenabled ads
image

@LaurenWags LaurenWags mentioned this issue Aug 4, 2020
Closed
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.109 x64 build

  • Verified no ads are shown when ads is turned off
  • Verified no ads are shown when rewards is turned off

@jsecretan jsecretan added OS/Android Fixes related to Android browser functionality and removed OS/Android Fixes related to Android browser functionality labels Aug 10, 2020
@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
@srirambv srirambv mentioned this issue Aug 18, 2020
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes "Bat Ads Service" should only be running if Brave Ads is enabled brave/brave-core
8 participants
@jsecretan @tmancey @rebron @NejcZdovc @srirambv @LaurenWags @btlechowski @GeetaSarvadnya