Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust compiler to latest stable (1.43.1) #9422

Closed
gpestana opened this issue Apr 23, 2020 · 0 comments · Fixed by brave/brave-core#5695
Closed

Update Rust compiler to latest stable (1.43.1) #9422

gpestana opened this issue Apr 23, 2020 · 0 comments · Fixed by brave/brave-core#5695

Comments

@gpestana
Copy link

Description

The cxx crate, which can be used to avoid using unsafe Rust code in FFIs, requires that the rustc compiler version is 1.42+ . Updating the current Rust toolchain (which uses rustc 1.41) would allow us to use it.

Steps to Reproduce

RUSTUP_HOME=build/rustup/0.1.2 rustc -V

Actual result:

1.41.2

Expected result:

rustc 1.42.0 (b8cedc004 2020-03-09)

Reproduces how often:

Always

@gpestana gpestana changed the title Update Rust compiler to 1.42.0 Update Rust compiler to latest stable (1.43.0) Apr 25, 2020
@tmancey tmancey changed the title Update Rust compiler to latest stable (1.43.0) Update Rust compiler to latest stable (1.43.1) May 30, 2020
@tmancey tmancey self-assigned this May 30, 2020
@tmancey tmancey added the QA/No label May 30, 2020
@tmancey tmancey added this to the 1.11.x - Nightly milestone May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants