Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Use defined center for Sponsored images #9426

Closed
deeppandya opened this issue Apr 23, 2020 · 1 comment · Fixed by brave/brave-core#5349
Closed

[Android] Use defined center for Sponsored images #9426

deeppandya opened this issue Apr 23, 2020 · 1 comment · Fixed by brave/brave-core#5349

Comments

@deeppandya
Copy link

https://bravesoftware.slack.com/archives/CQGTGBNH1/p1587658271168500?thread_ts=1587615215.165300&cid=CQGTGBNH1

Description

Andriod appears to be ignoring the defined center and using actual center instead.

Steps to reproduce

Actual result

Sponsored image appears to be using actual center.

Expected result

Sponsored image should use the defined center.

Issue reproduces how often

Issue happens on

  • Current Play Store version? yes
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.7.102 x64 stable build

  • Verified focal point for SI is centred as per spec
    image
    image
    image
    image
    image
    image

Verification passed on Samsung Tab A with Android 9 running 1.7.102 x64 stable build

  • Verified focal point for SI is centred as per spec
    image
    image
    image
    image
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants