Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] User wallets not permitted up to a threshold of BAT earner #9636

Closed
mandar-brave opened this issue May 5, 2020 · 7 comments · Fixed by brave/brave-core#5698
Closed
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/include

Comments

@mandar-brave
Copy link

Issue: Currently a lot of users are being pushed in to the user wallet funnel w/o having a lot of earned BAT creating a load for the wallet partner.

Fix: Prevent any UI to trigger 'Verify Wallet' until XX BAT has been earned as a virtual grant before user is allowed to verify their user wallet.

Please block user wallet release on to Android until fix for this issue is made. We will lead with Android and make fix on Desktop after that.

cc @aekeus @LaurenWags @kjozwiak @jamesmudgett

@mandar-brave mandar-brave added priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Android Fixes related to Android browser functionality labels May 5, 2020
@anthonypkeane anthonypkeane added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label May 5, 2020
@anthonypkeane
Copy link

@gdregalo This will need to be added to 1.9.x along with User Wallets

@bradleyrichter and co are working on a design, but it may be very simple. More TBD

@anthonypkeane
Copy link

@mandar-brave
Copy link
Author

mandar-brave commented May 13, 2020

Here is what the plan is;

  1. for users that have not yet accrued 25 BAT, we gray out the Verify Wallet button - they know the button is there but it does not take them to the verify link
  2. Remove the Add funds and Withdraw buttons till Verification button is available
  3. for users that have reached the 25 BAT limit, follow the current design.
  4. Add a tooltip for the gray out that says "25 BAT limit required to Verify Wallet"

@anthonypkeane if the tooltip is OK, we need to order translations. I am OK to live w/o it.

@kjozwiak @LaurenWags @jamesmudgett

@anthonypkeane anthonypkeane removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label May 14, 2020
@jenn-rhim
Copy link

  1. We don't show the Verify button at all.
  2. Verify screen will come up when relevant actions are requested by the user: i.e. Add Funds and Withdraw Funds.
  3. I'd prefer not graying out the button based on the condition, so we can educate user when they click what condition needs to be met.
    @mandar-brave

@jenn-rhim
Copy link

The overlay info box that comes up when clicked these button while > 25BAT is in their balance, would say:

'To complete this action, you need to verify your wallet t. Minimum balance 25 BAT is required to verify.’

@mandar-brave
Copy link
Author

@NejcZdovc @emerick we need to get this done for the 1.10 release.

@btlechowski
Copy link

btlechowski commented Jun 17, 2020

Verification passed on BraveModernarm v1.10.92 on Samsung Galaxy Tab S5e (Android 9.0)

Verified that Verified Wallet is grayed out.
Screenshot_20200617-051522_Brave

Verified clicking on Verified Wallet shows expected message
Screenshot_20200617-051549_Brave

Verified that if condition of 25BAT is met, Verified Wallet stops being grayed out and is active
Screenshot_20200617-051746_Brave

Verified that if condition of 25BAT is met, verification can be completed successfully
Screenshot_20200617-050825_Brave

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.10.92.apk

  • Verified that Verify Wallet is greyed out when anon user wallet balance is less than 25 BAT

  • Verified that use can't link uphold account when anon user wallet balance is less than 25 BAT.

  • Verified that click on Verify Wallet shows the message as A minimum balance of 25 BAT is required to verify when anon wallet balance is less than 25 BAT
    Screenshot_2020-06-17-16-12-06

  • Verified that Verify wallet button color changed to blue when anon user wallet balance is greater than 25 BAT
    Screenshot_2020-06-17-16-26-24

  • Verified that use can link uphold account when anon user wallet balance is greater than 25 BAT.
    Screenshot_2020-06-17-16-23-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants