Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DEP Omaha to 1.3.361.149 #21814

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Jan 30, 2024

The motivations are to bring us up-to-date with upstream and to incorporate some security fixes.

Resolves brave/brave-browser#35684.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Use Brave Manager to remove all copies of Brave and Omaha from your system. Then, please make sure that the following still work:

  • Brave's various Windows installers.
  • On-demand updates via brave://settings/help.
  • Background updates via the Windows Task Scheduler.

Feel free to ask me if you have any questions about this.

@mherrmann mherrmann self-assigned this Jan 30, 2024
@mherrmann mherrmann requested a review from a team as a code owner January 30, 2024 06:28
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 30, 2024
The motivations are to bring us up-to-date with upstream and to
incorporate some security fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Omaha v1.3.361.149 for new users
2 participants