From eb33307440c42cb6428b82d09cb01e8457ade45c Mon Sep 17 00:00:00 2001 From: srirambv Date: Mon, 20 Mar 2017 16:34:20 +0000 Subject: [PATCH 1/2] Added release notes link to about:brave Changed href to point to installed ver --- app/extensions/brave/locales/en-US/app.properties | 5 +++++ js/about/brave.js | 14 +++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/app/extensions/brave/locales/en-US/app.properties b/app/extensions/brave/locales/en-US/app.properties index 2c56922d9d4..dc6b6694572 100644 --- a/app/extensions/brave/locales/en-US/app.properties +++ b/app/extensions/brave/locales/en-US/app.properties @@ -16,6 +16,11 @@ submit=Submit settings=Settings aboutPages=About pages aboutBrave=About Brave +braveInfo=Browse faster and safer with Brave. +releaseNotes=Release Notes +relNotesInfo1=Click +relNotesInfo2=here +relNotesInfo3=to view the release notes. versionInformation=Version Information listOfAboutPages=List of about pages history=History diff --git a/js/about/brave.js b/js/about/brave.js index 2bab7a98d91..9d82f04770e 100644 --- a/js/about/brave.js +++ b/js/about/brave.js @@ -38,7 +38,19 @@ class AboutBrave extends React.Component { render () { return
-
+
+
+
+ +
+
+
+
+   +   + +
+
From 07a49902262239d8c1f0872e2129a39811e45599 Mon Sep 17 00:00:00 2001 From: Brian Clifton Date: Tue, 4 Apr 2017 11:21:31 -0700 Subject: [PATCH 2/2] Implemented feedback by @bradleyrichter Auditors: @srirambv --- app/localShortcuts.js | 24 ++++++++++++------------ js/about/brave.js | 22 +++++++++++++--------- less/about/brave.less | 4 ++++ 3 files changed, 29 insertions(+), 21 deletions(-) diff --git a/app/localShortcuts.js b/app/localShortcuts.js index f285cb01316..f0a756d9c78 100644 --- a/app/localShortcuts.js +++ b/app/localShortcuts.js @@ -40,20 +40,20 @@ module.exports.register = (win) => { ['Alt+Left', messages.SHORTCUT_ACTIVE_FRAME_BACK], ['Alt+Right', messages.SHORTCUT_ACTIVE_FRAME_FORWARD]) } else { - // Different shorcut for View Source as is common for Chrome/Safari on macOS - // See #7702 + // Different shorcut for View Source as is common for Chrome/Safari on macOS + // See #7702 + simpleWebContentEvents.push( + ['Cmd+Alt+U', messages.SHORTCUT_ACTIVE_FRAME_VIEW_SOURCE] + ) + + if (process.env.NODE_ENV !== 'development') { + // We're in Darwin and release or test mode... + // We disable for development mode because Browser level dev tools copy doesn't work. + // Workaround for #1060 simpleWebContentEvents.push( - ['Cmd+Alt+U', messages.SHORTCUT_ACTIVE_FRAME_VIEW_SOURCE] + ['Cmd+C', messages.SHORTCUT_ACTIVE_FRAME_COPY] ) - - if (process.env.NODE_ENV !== 'development') { - // We're in Darwin and release or test mode... - // We disable for development mode because Browser level dev tools copy doesn't work. - // Workaround for #1060 - simpleWebContentEvents.push( - ['Cmd+C', messages.SHORTCUT_ACTIVE_FRAME_COPY] - ) - } + } } // Tab ordering shortcuts diff --git a/js/about/brave.js b/js/about/brave.js index 9d82f04770e..b7261e1dbb1 100644 --- a/js/about/brave.js +++ b/js/about/brave.js @@ -38,22 +38,25 @@ class AboutBrave extends React.Component { render () { return